From 3a6d06a8646965b1f49b9dbd7103af2ffc0bee2e Mon Sep 17 00:00:00 2001
From: Stone Gray <stone@stonegray.ca>
Date: Tue, 31 Jan 2023 12:56:07 -0500
Subject: [PATCH] Handle plist library failing to parse file

---
 package-lock.json         | 32 ++++++++++++++++----------------
 package.json              |  2 +-
 src/util/readPlistFile.js | 12 ++++++++++--
 3 files changed, 27 insertions(+), 19 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 792d9b5..fa465ee 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -14,7 +14,7 @@
       "dependencies": {
         "macos-release": "^2.5.0",
         "new-github-issue-url": "^0.2.1",
-        "plist": "^3.0.5",
+        "plist": "^3.0.6",
         "semver": "^7.3.7"
       },
       "devDependencies": {
@@ -987,12 +987,12 @@
       }
     },
     "node_modules/plist": {
-      "version": "3.0.5",
-      "resolved": "https://registry.npmjs.org/plist/-/plist-3.0.5.tgz",
-      "integrity": "sha512-83vX4eYdQp3vP9SxuYgEM/G/pJQqLUz/V/xzPrzruLs7fz7jxGQ1msZ/mg1nwZxUSuOp4sb+/bEIbRrbzZRxDA==",
+      "version": "3.0.6",
+      "resolved": "https://registry.npmjs.org/plist/-/plist-3.0.6.tgz",
+      "integrity": "sha512-WiIVYyrp8TD4w8yCvyeIr+lkmrGRd5u0VbRnU+tP/aRLxP/YadJUYOMZJ/6hIa3oUyVCsycXvtNRgd5XBJIbiA==",
       "dependencies": {
         "base64-js": "^1.5.1",
-        "xmlbuilder": "^9.0.7"
+        "xmlbuilder": "^15.1.1"
       },
       "engines": {
         "node": ">=6"
@@ -1292,11 +1292,11 @@
       "dev": true
     },
     "node_modules/xmlbuilder": {
-      "version": "9.0.7",
-      "resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-9.0.7.tgz",
-      "integrity": "sha1-Ey7mPS7FVlxVfiD0wi35rKaGsQ0=",
+      "version": "15.1.1",
+      "resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-15.1.1.tgz",
+      "integrity": "sha512-yMqGBqtXyeN1e3TGYvgNgDVZ3j84W4cwkOXQswghol6APgZWaff9lnbvN7MHYJOiXsvGPXtjTYJEiC9J2wv9Eg==",
       "engines": {
-        "node": ">=4.0"
+        "node": ">=8.0"
       }
     },
     "node_modules/yallist": {
@@ -2043,12 +2043,12 @@
       "dev": true
     },
     "plist": {
-      "version": "3.0.5",
-      "resolved": "https://registry.npmjs.org/plist/-/plist-3.0.5.tgz",
-      "integrity": "sha512-83vX4eYdQp3vP9SxuYgEM/G/pJQqLUz/V/xzPrzruLs7fz7jxGQ1msZ/mg1nwZxUSuOp4sb+/bEIbRrbzZRxDA==",
+      "version": "3.0.6",
+      "resolved": "https://registry.npmjs.org/plist/-/plist-3.0.6.tgz",
+      "integrity": "sha512-WiIVYyrp8TD4w8yCvyeIr+lkmrGRd5u0VbRnU+tP/aRLxP/YadJUYOMZJ/6hIa3oUyVCsycXvtNRgd5XBJIbiA==",
       "requires": {
         "base64-js": "^1.5.1",
-        "xmlbuilder": "^9.0.7"
+        "xmlbuilder": "^15.1.1"
       }
     },
     "prelude-ls": {
@@ -2262,9 +2262,9 @@
       "dev": true
     },
     "xmlbuilder": {
-      "version": "9.0.7",
-      "resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-9.0.7.tgz",
-      "integrity": "sha1-Ey7mPS7FVlxVfiD0wi35rKaGsQ0="
+      "version": "15.1.1",
+      "resolved": "https://registry.npmjs.org/xmlbuilder/-/xmlbuilder-15.1.1.tgz",
+      "integrity": "sha512-yMqGBqtXyeN1e3TGYvgNgDVZ3j84W4cwkOXQswghol6APgZWaff9lnbvN7MHYJOiXsvGPXtjTYJEiC9J2wv9Eg=="
     },
     "yallist": {
       "version": "4.0.0",
diff --git a/package.json b/package.json
index ef5e989..f6a1b49 100644
--- a/package.json
+++ b/package.json
@@ -34,7 +34,7 @@
   "dependencies": {
     "macos-release": "^2.5.0",
     "new-github-issue-url": "^0.2.1",
-    "plist": "^3.0.5",
+    "plist": "^3.0.6",
     "semver": "^7.3.7"
   },
   "devDependencies": {
diff --git a/src/util/readPlistFile.js b/src/util/readPlistFile.js
index f9740d6..44ef74c 100644
--- a/src/util/readPlistFile.js
+++ b/src/util/readPlistFile.js
@@ -16,5 +16,13 @@ export default async function readPlistFile(pluginPath) {
 		return e;
 	}
 
-	return plist.parse(fileContents);
-}
\ No newline at end of file
+	let retValue;
+	try {
+		retValue = plist.parse(fileContents);
+	} catch (e){
+		return e;
+	}
+
+	return retValue;
+
+}