From c7f08b4488abbba21a3d347240481ef71d87f35f Mon Sep 17 00:00:00 2001 From: Yunze Xu Date: Wed, 27 Jan 2021 16:41:21 +0800 Subject: [PATCH 1/2] Add error logs for flaky testCreateInvalidTopics --- .../pulsar/handlers/kop/KafkaRequestHandlerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java b/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java index d689a52d1c..66613a6937 100644 --- a/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java +++ b/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java @@ -355,7 +355,7 @@ public void testCreateInvalidTopics() { createTopicsByKafkaAdmin(kafkaAdmin, topicToNumPartitions); fail("create a invalid topic should fail"); } catch (Exception e) { - log.info("Failed to create topics: {}", topicToNumPartitions); + log.info("Failed to create topics: {} caused by {}", topicToNumPartitions, e.getCause()); assertTrue(e.getCause() instanceof TimeoutException); } } From 11bf96f6768f2475c66f44a7b95c29670fcbfb5d Mon Sep 17 00:00:00 2001 From: Yunze Xu Date: Wed, 27 Jan 2021 20:53:06 +0800 Subject: [PATCH 2/2] Fix testCreateInvalidTopics --- .../pulsar/handlers/kop/KafkaRequestHandlerTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java b/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java index 66613a6937..d82578b5d0 100644 --- a/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java +++ b/tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandlerTest.java @@ -61,6 +61,7 @@ import org.apache.kafka.common.TopicPartition; import org.apache.kafka.common.config.ConfigResource; import org.apache.kafka.common.errors.TimeoutException; +import org.apache.kafka.common.errors.UnknownServerException; import org.apache.kafka.common.errors.UnknownTopicOrPartitionException; import org.apache.kafka.common.protocol.ApiKeys; import org.apache.kafka.common.protocol.Errors; @@ -356,7 +357,8 @@ public void testCreateInvalidTopics() { fail("create a invalid topic should fail"); } catch (Exception e) { log.info("Failed to create topics: {} caused by {}", topicToNumPartitions, e.getCause()); - assertTrue(e.getCause() instanceof TimeoutException); + final Throwable cause = e.getCause(); + assertTrue(cause instanceof TimeoutException || cause instanceof UnknownServerException); } }