From c3f24e7dce5aaaea9324fd7a3be2f0f2f38ab880 Mon Sep 17 00:00:00 2001 From: ccoVeille <3875889+ccoVeille@users.noreply.github.com> Date: Tue, 13 May 2025 14:41:26 +0200 Subject: [PATCH] assert.ErrorAs: simplify retrieving the type name --- assert/assertions.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/assert/assertions.go b/assert/assertions.go index 46582060d..c4754cbb9 100644 --- a/assert/assertions.go +++ b/assert/assertions.go @@ -2225,17 +2225,17 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{ return true } - expectedText := reflect.ValueOf(target).Elem().Type().String() + expectedType := reflect.TypeOf(target).Elem().String() if err == nil { return Fail(t, fmt.Sprintf("An error is expected but got nil.\n"+ - "expected: %s", expectedText), msgAndArgs...) + "expected: %s", expectedType), msgAndArgs...) } chain := buildErrorChainString(err, true) return Fail(t, fmt.Sprintf("Should be in error chain:\n"+ "expected: %s\n"+ - "in chain: %s", expectedText, chain, + "in chain: %s", expectedType, chain, ), msgAndArgs...) } @@ -2253,7 +2253,7 @@ func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interfa return Fail(t, fmt.Sprintf("Target error should not be in err chain:\n"+ "found: %s\n"+ - "in chain: %s", reflect.ValueOf(target).Elem().Type(), chain, + "in chain: %s", reflect.TypeOf(target).Elem().String(), chain, ), msgAndArgs...) }