Skip to content

Comments

parse PROVIDED_IN_ROOT correctly#10160

Open
manbearwiz wants to merge 2 commits intoswagger-api:masterfrom
manbearwiz:fix/provided-in-root-type
Open

parse PROVIDED_IN_ROOT correctly#10160
manbearwiz wants to merge 2 commits intoswagger-api:masterfrom
manbearwiz:fix/provided-in-root-type

Conversation

@manbearwiz
Copy link
Contributor

@manbearwiz manbearwiz commented Apr 6, 2020

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When running the codegen integration in SwaggerHub, if you check the "providedInRoot" option in Codegen options, the integration fails saying

The 'Azure DevOps Services' plugin failed with the following error: java.lang.Boolean cannot be cast to java.lang.String

This change fixes this by parsing PROVIDED_IN_ROOT the same way as other booleans, Boolean.parseBoolean(additionalProperties.get(KEY).toString()). It also changes the default to true on angular versions ^6.0.0.

See also OpenAPITools/openapi-generator#3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant