minor #49253 [PHPUnit 10] Use TestCase suffix for abstract tests in /Tests/ (OskarStark)

nicolas-grekas · nicolas-grekas · commit 4b81c203691e · 2023-02-07T10:38:40.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs symfony/symfony#49233 | License | MIT | Doc PR | n/a Replaces #49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony/symfony#49233 Commits ------- cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
diff --git a/Tests/Descriptor/AbstractDescriptorTestCase.php b/Tests/Descriptor/AbstractDescriptorTestCase.php
@@ -19,7 +19,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\BufferedOutput;
 
-abstract class AbstractDescriptorTest extends TestCase
+abstract class AbstractDescriptorTestCase extends TestCase
 {
     /** @dataProvider getDescribeInputArgumentTestData */
     public function testDescribeInputArgument(InputArgument $argument, $expectedDescription)
diff --git a/Tests/Descriptor/JsonDescriptorTest.php b/Tests/Descriptor/JsonDescriptorTest.php
@@ -13,7 +13,7 @@
 
 use Symfony\Component\Console\Descriptor\JsonDescriptor;
 
-class JsonDescriptorTest extends AbstractDescriptorTest
+class JsonDescriptorTest extends AbstractDescriptorTestCase
 {
     protected function getDescriptor()
     {
diff --git a/Tests/Descriptor/MarkdownDescriptorTest.php b/Tests/Descriptor/MarkdownDescriptorTest.php
@@ -15,7 +15,7 @@
 use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;
 use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;
 
-class MarkdownDescriptorTest extends AbstractDescriptorTest
+class MarkdownDescriptorTest extends AbstractDescriptorTestCase
 {
     public static function getDescribeCommandTestData()
     {
diff --git a/Tests/Descriptor/TextDescriptorTest.php b/Tests/Descriptor/TextDescriptorTest.php
@@ -16,7 +16,7 @@
 use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;
 use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;
 
-class TextDescriptorTest extends AbstractDescriptorTest
+class TextDescriptorTest extends AbstractDescriptorTestCase
 {
     public static function getDescribeCommandTestData()
     {
diff --git a/Tests/Descriptor/XmlDescriptorTest.php b/Tests/Descriptor/XmlDescriptorTest.php
@@ -13,7 +13,7 @@
 
 use Symfony\Component\Console\Descriptor\XmlDescriptor;
 
-class XmlDescriptorTest extends AbstractDescriptorTest
+class XmlDescriptorTest extends AbstractDescriptorTestCase
 {
     protected function getDescriptor()
     {
diff --git a/Tests/Helper/AbstractQuestionHelperTestCase.php b/Tests/Helper/AbstractQuestionHelperTestCase.php
@@ -14,7 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Input\StreamableInputInterface;
 
-abstract class AbstractQuestionHelperTest extends TestCase
+abstract class AbstractQuestionHelperTestCase extends TestCase
 {
     protected function createStreamableInputInterfaceMock($stream = null, $interactive = true)
     {
diff --git a/Tests/Helper/QuestionHelperTest.php b/Tests/Helper/QuestionHelperTest.php
@@ -30,7 +30,7 @@
 /**
  * @group tty
  */
-class QuestionHelperTest extends AbstractQuestionHelperTest
+class QuestionHelperTest extends AbstractQuestionHelperTestCase
 {
     public function testAskChoice()
     {
diff --git a/Tests/Helper/SymfonyQuestionHelperTest.php b/Tests/Helper/SymfonyQuestionHelperTest.php
@@ -23,7 +23,7 @@
 /**
  * @group tty
  */
-class SymfonyQuestionHelperTest extends AbstractQuestionHelperTest
+class SymfonyQuestionHelperTest extends AbstractQuestionHelperTestCase
 {
     public function testAskChoice()
     {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`use Symfony\Component\Console\Input\InputOption;`
`20`	`20`	`use Symfony\Component\Console\Output\BufferedOutput;`
`21`	`21`
`22`		`-abstract class AbstractDescriptorTest extends TestCase`
	`22`	`+abstract class AbstractDescriptorTestCase extends TestCase`
`23`	`23`	`{`
`24`	`24`	`/** @dataProvider getDescribeInputArgumentTestData */`
`25`	`25`	`public function testDescribeInputArgument(InputArgument $argument, $expectedDescription)`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\Console\Descriptor\JsonDescriptor;`
`15`	`15`
`16`		`-class JsonDescriptorTest extends AbstractDescriptorTest`
	`16`	`+class JsonDescriptorTest extends AbstractDescriptorTestCase`
`17`	`17`	`{`
`18`	`18`	`protected function getDescriptor()`
`19`	`19`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;`
`16`	`16`	`use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;`
`17`	`17`
`18`		`-class MarkdownDescriptorTest extends AbstractDescriptorTest`
	`18`	`+class MarkdownDescriptorTest extends AbstractDescriptorTestCase`
`19`	`19`	`{`
`20`	`20`	`public static function getDescribeCommandTestData()`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;`
`17`	`17`	`use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;`
`18`	`18`
`19`		`-class TextDescriptorTest extends AbstractDescriptorTest`
	`19`	`+class TextDescriptorTest extends AbstractDescriptorTestCase`
`20`	`20`	`{`
`21`	`21`	`public static function getDescribeCommandTestData()`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`use PHPUnit\Framework\TestCase;`
`15`	`15`	`use Symfony\Component\Console\Input\StreamableInputInterface;`
`16`	`16`
`17`		`-abstract class AbstractQuestionHelperTest extends TestCase`
	`17`	`+abstract class AbstractQuestionHelperTestCase extends TestCase`
`18`	`18`	`{`
`19`	`19`	`protected function createStreamableInputInterfaceMock($stream = null, $interactive = true)`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`/**`
`31`	`31`	`* @group tty`
`32`	`32`	`*/`
`33`		`-class QuestionHelperTest extends AbstractQuestionHelperTest`
	`33`	`+class QuestionHelperTest extends AbstractQuestionHelperTestCase`
`34`	`34`	`{`
`35`	`35`	`public function testAskChoice()`
`36`	`36`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`/**`
`24`	`24`	`* @group tty`
`25`	`25`	`*/`
`26`		`-class SymfonyQuestionHelperTest extends AbstractQuestionHelperTest`
	`26`	`+class SymfonyQuestionHelperTest extends AbstractQuestionHelperTestCase`
`27`	`27`	`{`
`28`	`28`	`public function testAskChoice()`
`29`	`29`	`{`