Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/LockTest.php

@@ -469,8 +469,8 @@ public function testAcquireReadTwiceWithExpiration()
         $key = new Key(uniqid(__METHOD__, true));
         $store = new class() implements PersistingStoreInterface {
             use ExpiringStoreTrait;
-            private $keys = [];
-            private $initialTtl = 30;
+            private array $keys = [];
+            private int $initialTtl = 30;
 
             public function save(Key $key): void
             {
@@ -513,8 +513,8 @@ public function testAcquireTwiceWithExpiration()
         $key = new Key(uniqid(__METHOD__, true));
         $store = new class() implements PersistingStoreInterface {
             use ExpiringStoreTrait;
-            private $keys = [];
-            private $initialTtl = 30;
+            private array $keys = [];
+            private int $initialTtl = 30;
 
             public function save(Key $key): void
             {

Tests/Store/AbstractRedisStoreTestCase.php

@@ -56,7 +56,7 @@ public function testBackwardCompatibility()
 
 class Symfony51Store
 {
-    private $redis;
+    private \Redis|Relay|\RedisCluster|\RedisArray|\Predis\ClientInterface $redis;
 
     public function __construct($redis)
     {

Tests/Store/CombinedStoreTest.php

@@ -50,14 +50,10 @@ public function getStore(): PersistingStoreInterface
         return new CombinedStore([new RedisStore($redis)], new UnanimousStrategy());
     }
 
-    /** @var MockObject&StrategyInterface */
-    private $strategy;
-    /** @var MockObject&BlockingStoreInterface */
-    private $store1;
-    /** @var MockObject&BlockingStoreInterface */
-    private $store2;
-    /** @var CombinedStore */
-    private $store;
+    private MockObject&StrategyInterface $strategy;
+    private MockObject&BlockingStoreInterface $store1;
+    private MockObject&BlockingStoreInterface $store2;
+    private CombinedStore $store;
 
     protected function setUp(): void
     {

Tests/Store/DoctrineDbalStoreTest.php

@@ -33,7 +33,7 @@ class DoctrineDbalStoreTest extends AbstractStoreTestCase
 {
     use ExpiringStoreTestTrait;
 
-    protected static $dbFile;
+    protected static string $dbFile;
 
     public static function setUpBeforeClass(): void
     {

Tests/Store/PdoStoreTest.php

@@ -27,7 +27,7 @@ class PdoStoreTest extends AbstractStoreTestCase
 {
     use ExpiringStoreTestTrait;
 
-    protected static $dbFile;
+    protected static string $dbFile;
 
     public static function setUpBeforeClass(): void
     {

Tests/Strategy/ConsensusStrategyTest.php

@@ -19,8 +19,7 @@
  */
 class ConsensusStrategyTest extends TestCase
 {
-    /** @var ConsensusStrategy */
-    private $strategy;
+    private ConsensusStrategy $strategy;
 
     protected function setUp(): void
     {

Tests/Strategy/UnanimousStrategyTest.php

@@ -19,8 +19,7 @@
  */
 class UnanimousStrategyTest extends TestCase
 {
-    /** @var UnanimousStrategy */
-    private $strategy;
+    private UnanimousStrategy $strategy;
 
     protected function setUp(): void
     {