bug #52272 [VarDump] Fix order of dumped properties - parent goes first (lyrixx)

This PR was merged into the 6.4 branch.

Discussion
----------

[VarDump] Fix order of dumped properties - parent goes first

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? |
| Issues        |
| License       | MIT

Commits
-------

900d271a28 [VarDump] Fix order of dumped properties - parent goes first

Author: nicolas-grekas

Caster/Caster.php

@@ -177,6 +177,10 @@ private static function getClassProperties(\ReflectionClass $class): array
         $classProperties = [];
         $className = $class->name;
 
+        if ($parent = $class->getParentClass()) {
+            $classProperties += self::$classProperties[$parent->name] ??= self::getClassProperties($parent);
+        }
+
         foreach ($class->getProperties() as $p) {
             if ($p->isStatic()) {
                 continue;
@@ -189,10 +193,6 @@ private static function getClassProperties(\ReflectionClass $class): array
             }] = new UninitializedStub($p);
         }
 
-        if ($parent = $class->getParentClass()) {
-            $classProperties += self::$classProperties[$parent->name] ??= self::getClassProperties($parent);
-        }
-
         return $classProperties;
     }
 }

Tests/Caster/CasterTest.php

@@ -185,4 +185,32 @@ public function __debugInfo(): array
             }
         });
     }
+
+    public function testClassHierarchy()
+    {
+        $this->assertDumpMatchesFormat(<<<'DUMP'
+            Symfony\Component\VarDumper\Tests\Caster\B {
+              +a: "a"
+              #b: "b"
+              -c: "c"
+              +d: "d"
+              #e: "e"
+              -f: "f"
+            }
+            DUMP, new B());
+    }
+}
+
+class A
+{
+    public $a = 'a';
+    protected $b = 'b';
+    private $c = 'c';
+}
+
+class B extends A
+{
+    public $d = 'd';
+    protected $e = 'e';
+    private $f = 'f';
 }