Add void return types

Author: wouterj

Caster/RdKafkaCaster.php

@@ -31,6 +31,9 @@
  */
 class RdKafkaCaster
 {
+    /**
+     * @return array
+     */
     public static function castKafkaConsumer(KafkaConsumer $c, array $a, Stub $stub, bool $isNested)
     {
         $prefix = Caster::PREFIX_VIRTUAL;
@@ -123,6 +126,9 @@ public static function castTopicConf(TopicConf $c, array $a, Stub $stub, bool $i
         return $a;
     }
 
+    /**
+     * @return array
+     */
     public static function castRdKafka(\RdKafka $c, array $a, Stub $stub, bool $isNested)
     {
         $prefix = Caster::PREFIX_VIRTUAL;

Caster/ReflectionCaster.php

@@ -84,7 +84,7 @@ public static function unsetClosureFileInfo(\Closure $c, array $a)
         return $a;
     }
 
-    public static function castGenerator(\Generator $c, array $a, Stub $stub, bool $isNested)
+    public static function castGenerator(\Generator $c, array $a, Stub $stub, bool $isNested): array
     {
         // Cannot create ReflectionGenerator based on a terminated Generator
         try {
@@ -447,7 +447,7 @@ public static function getSignature(array $a)
         return $signature;
     }
 
-    private static function addExtra(array &$a, \Reflector $c)
+    private static function addExtra(array &$a, \Reflector $c): void
     {
         $x = isset($a[Caster::PREFIX_VIRTUAL.'extra']) ? $a[Caster::PREFIX_VIRTUAL.'extra']->value : [];
 
@@ -463,7 +463,7 @@ private static function addExtra(array &$a, \Reflector $c)
         }
     }
 
-    private static function addMap(array &$a, object $c, array $map, string $prefix = Caster::PREFIX_VIRTUAL)
+    private static function addMap(array &$a, object $c, array $map, string $prefix = Caster::PREFIX_VIRTUAL): void
     {
         foreach ($map as $k => $m) {
             if ('isDisabled' === $k) {

Caster/ResourceCaster.php

@@ -46,7 +46,7 @@ public static function castProcess($process, array $a, Stub $stub, bool $isNeste
         return proc_get_status($process);
     }
 
-    public static function castStream($stream, array $a, Stub $stub, bool $isNested)
+    public static function castStream($stream, array $a, Stub $stub, bool $isNested): array
     {
         $a = stream_get_meta_data($stream) + static::castStreamContext($stream, $a, $stub, $isNested);
         if ($a['uri'] ?? false) {

Cloner/AbstractCloner.php

@@ -232,6 +232,8 @@ public function __construct(array $casters = null)
      * see e.g. static::$defaultCasters.
      *
      * @param callable[] $casters A map of casters
+     *
+     * @return void
      */
     public function addCasters(array $casters)
     {
@@ -242,6 +244,8 @@ public function addCasters(array $casters)
 
     /**
      * Sets the maximum number of items to clone past the minimum depth in nested structures.
+     *
+     * @return void
      */
     public function setMaxItems(int $maxItems)
     {
@@ -250,6 +254,8 @@ public function setMaxItems(int $maxItems)
 
     /**
      * Sets the maximum cloned length for strings.
+     *
+     * @return void
      */
     public function setMaxString(int $maxString)
     {
@@ -259,6 +265,8 @@ public function setMaxString(int $maxString)
     /**
      * Sets the minimum tree depth where we are guaranteed to clone all the items.  After this
      * depth is reached, only setMaxItems items will be cloned.
+     *
+     * @return void
      */
     public function setMinDepth(int $minDepth)
     {

Cloner/Data.php

@@ -262,6 +262,8 @@ public function seek(string|int $key): ?static
 
     /**
      * Dumps data with a DumperInterface dumper.
+     *
+     * @return void
      */
     public function dump(DumperInterface $dumper)
     {
@@ -286,7 +288,7 @@ public function dump(DumperInterface $dumper)
      *
      * @param mixed $item A Stub object or the original value being dumped
      */
-    private function dumpItem(DumperInterface $dumper, Cursor $cursor, array &$refs, mixed $item)
+    private function dumpItem(DumperInterface $dumper, Cursor $cursor, array &$refs, mixed $item): void
     {
         $cursor->refIndex = 0;
         $cursor->softRefTo = $cursor->softRefHandle = $cursor->softRefCount = 0;

Command/ServerDumpCommand.php

@@ -54,7 +54,7 @@ public function __construct(DumpServer $server, array $descriptors = [])
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->addOption('format', null, InputOption::VALUE_REQUIRED, sprintf('The output format (%s)', implode(', ', $this->getAvailableFormats())), 'cli')

Dumper/AbstractDumper.php

@@ -155,6 +155,8 @@ public function dump(Data $data, $output = null): ?string
      *
      * @param int $depth The recursive depth in the dumped structure for the line being dumped,
      *                   or -1 to signal the end-of-dump to the line dumper callable
+     *
+     * @return void
      */
     protected function dumpLine(int $depth)
     {
@@ -164,6 +166,8 @@ protected function dumpLine(int $depth)
 
     /**
      * Generic line dumper callback.
+     *
+     * @return void
      */
     protected function echoLine(string $line, int $depth, string $indentPad)
     {

Dumper/CliDumper.php

@@ -86,6 +86,8 @@ public function __construct($output = null, string $charset = null, int $flags =
 
     /**
      * Enables/disables colored output.
+     *
+     * @return void
      */
     public function setColors(bool $colors)
     {
@@ -94,6 +96,8 @@ public function setColors(bool $colors)
 
     /**
      * Sets the maximum number of characters per line for dumped strings.
+     *
+     * @return void
      */
     public function setMaxStringWidth(int $maxStringWidth)
     {
@@ -104,6 +108,8 @@ public function setMaxStringWidth(int $maxStringWidth)
      * Configures styles.
      *
      * @param array $styles A map of style names to style definitions
+     *
+     * @return void
      */
     public function setStyles(array $styles)
     {
@@ -114,12 +120,17 @@ public function setStyles(array $styles)
      * Configures display options.
      *
      * @param array $displayOptions A map of display options to customize the behavior
+     *
+     * @return void
      */
     public function setDisplayOptions(array $displayOptions)
     {
         $this->displayOptions = $displayOptions + $this->displayOptions;
     }
 
+    /**
+     * @return void
+     */
     public function dumpScalar(Cursor $cursor, string $type, string|int|float|bool|null $value)
     {
         $this->dumpKey($cursor);
@@ -175,6 +186,9 @@ public function dumpScalar(Cursor $cursor, string $type, string|int|float|bool|n
         $this->endValue($cursor);
     }
 
+    /**
+     * @return void
+     */
     public function dumpString(Cursor $cursor, string $str, bool $bin, int $cut)
     {
         $this->dumpKey($cursor);
@@ -260,6 +274,9 @@ public function dumpString(Cursor $cursor, string $str, bool $bin, int $cut)
         }
     }
 
+    /**
+     * @return void
+     */
     public function enterHash(Cursor $cursor, int $type, string|int|null $class, bool $hasChild)
     {
         $this->colors ??= $this->supportsColors();
@@ -296,6 +313,9 @@ public function enterHash(Cursor $cursor, int $type, string|int|null $class, boo
         }
     }
 
+    /**
+     * @return void
+     */
     public function leaveHash(Cursor $cursor, int $type, string|int|null $class, bool $hasChild, int $cut)
     {
         if (empty($cursor->attr['cut_hash'])) {
@@ -311,6 +331,8 @@ public function leaveHash(Cursor $cursor, int $type, string|int|null $class, boo
      *
      * @param bool $hasChild When the dump of the hash has child item
      * @param int  $cut      The number of items the hash has been cut by
+     *
+     * @return void
      */
     protected function dumpEllipsis(Cursor $cursor, bool $hasChild, int $cut)
     {
@@ -327,6 +349,8 @@ protected function dumpEllipsis(Cursor $cursor, bool $hasChild, int $cut)
 
     /**
      * Dumps a key in a hash structure.
+     *
+     * @return void
      */
     protected function dumpKey(Cursor $cursor)
     {
@@ -530,6 +554,9 @@ protected function supportsColors(): bool
         return static::$defaultColors = $this->hasColorSupport($h);
     }
 
+    /**
+     * @return void
+     */
     protected function dumpLine(int $depth, bool $endOfValue = false)
     {
         if ($this->colors) {
@@ -538,6 +565,9 @@ protected function dumpLine(int $depth, bool $endOfValue = false)
         parent::dumpLine($depth);
     }
 
+    /**
+     * @return void
+     */
     protected function endValue(Cursor $cursor)
     {
         if (-1 === $cursor->hashType) {

Dumper/ContextualizedDumper.php

@@ -31,6 +31,9 @@ public function __construct(DataDumperInterface $wrappedDumper, array $contextPr
         $this->contextProviders = $contextProviders;
     }
 
+    /**
+     * @return void
+     */
     public function dump(Data $data)
     {
         $context = $data->getContext();

Dumper/ServerDumper.php

@@ -41,6 +41,9 @@ public function getContextProviders(): array
         return $this->connection->getContextProviders();
     }
 
+    /**
+     * @return void
+     */
     public function dump(Data $data)
     {
         if (!$this->connection->write($data) && $this->wrappedDumper) {