SDL: Allow window resizing #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Nov 5, 2022
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Eliminate the compilation warnings below:
src/syscall_sdl.c: In function ‘syscall_draw_frame’:
src/syscall_sdl.c:234:31: warning: passing argument 2 of ‘SDL_GetWindowSize’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
234 | SDL_GetWindowSize(window, &width, &height);
| ^~~~~~
In file included from /usr/include/SDL2/SDL_events.h:33,
from /usr/include/SDL2/SDL.h:41,
from src/syscall_sdl.c:13:
/usr/include/SDL2/SDL_video.h:968:74: note: expected ‘int *’ but argument is of type ‘const uint[32](https://github.com/sysprog21/rv32emu/actions/runs/3400781244/jobs/5655438370#step:4:33)_t *’ {aka ‘const unsigned int *’}
968 | extern DECLSPEC void SDLCALL SDL_GetWindowSize(SDL_Window * window, int *w,
| ~~~~~^
src/syscall_sdl.c:234:39: warning: passing argument 3 of ‘SDL_GetWindowSize’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
234 | SDL_GetWindowSize(window, &width, &height);
| ^~~~~~~
In file included from /usr/include/SDL2/SDL_events.h:[33](https://github.com/sysprog21/rv32emu/actions/runs/3400781244/jobs/5655438370#step:4:34),
from /usr/include/SDL2/SDL.h:41,
from src/syscall_sdl.c:13:
/usr/include/SDL2/SDL_video.h:969:53: note: expected ‘int *’ but argument is of type ‘const uint32_t *’ {aka ‘const unsigned int *’}
969 | int *h);
| ~~~~~^
Contributor
|
File |
alanjian85
force-pushed
the
master
branch
2 times, most recently
from
88650df to
d33e2db
Compare
jserv
reviewed
Nov 5, 2022
Support window resizing by automatically updating the saved width/height of the window and rendering with that size without the need of reallocating the internal texture. Close sysprog21#73
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
SDL: Allow window resizing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support window resizing by automatically updating the saved width/height of the window and rendering with that size without the need of reallocating the internal texture.
Close #73