From 03e7ddb1169d6b31dfd781461583ae533d851baa Mon Sep 17 00:00:00 2001 From: Ahmad Lobany Date: Thu, 14 Jul 2022 12:15:26 +0300 Subject: [PATCH 1/3] ttl in getBid passing fix --- modules/taboolaBidAdapter.js | 4 ++-- package-lock.json | 2 +- test/spec/modules/taboolaBidAdapter_spec.js | 26 +++++++++++++++++++++ 3 files changed, 29 insertions(+), 3 deletions(-) diff --git a/modules/taboolaBidAdapter.js b/modules/taboolaBidAdapter.js index 1a35f9e54..32480f249 100644 --- a/modules/taboolaBidAdapter.js +++ b/modules/taboolaBidAdapter.js @@ -224,7 +224,7 @@ function getBid(requestId, currency, bidResponse) { } const { - price: cpm, crid: creativeId, adm: ad, w: width, h: height, adomain: advertiserDomains, meta = {} + price: cpm, crid: creativeId, adm: ad, w: width, h: height, exp: ttl, adomain: advertiserDomains, meta = {} } = bidResponse; if (advertiserDomains && advertiserDomains.length > 0) { @@ -233,7 +233,7 @@ function getBid(requestId, currency, bidResponse) { return { requestId, - ttl: 60, + ttl, mediaType: BANNER, cpm, creativeId, diff --git a/package-lock.json b/package-lock.json index 8a024f8c1..c126c5d4a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6,7 +6,7 @@ "packages": { "": { "name": "prebid.js", - "version": "6.28.0-pre", + "version": "7.4.0-pre", "license": "Apache-2.0", "dependencies": { "@babel/core": "^7.16.7", diff --git a/test/spec/modules/taboolaBidAdapter_spec.js b/test/spec/modules/taboolaBidAdapter_spec.js index 4749a6a59..16420b72d 100644 --- a/test/spec/modules/taboolaBidAdapter_spec.js +++ b/test/spec/modules/taboolaBidAdapter_spec.js @@ -311,6 +311,7 @@ describe('Taboola Adapter', function () { 'crid': '278195503434041083381', 'w': 300, 'h': 250, + 'exp': 60, 'lurl': 'http://us-trc.taboola.com/sample' } ], @@ -386,6 +387,31 @@ describe('Taboola Adapter', function () { const res = spec.interpretResponse(serverResponse, request) expect(res).to.deep.equal(expectedRes) }); + + it('should set the correct ttl form the response', function () { + // set exp-ttl to be 125 + const [bid] = serverResponse.body.seatbid[0].bid; + serverResponse.body.seatbid[0].bid[0].exp = 125 + const expectedRes = [ + { + requestId: request.bids[0].bidId, + cpm: bid.price, + creativeId: bid.crid, + ttl: 125, + netRevenue: false, + currency: serverResponse.body.cur, + mediaType: 'banner', + ad: bid.adm, + width: bid.w, + height: bid.h, + meta: { + 'advertiserDomains': bid.adomain + }, + } + ] + const res = spec.interpretResponse(serverResponse, request) + expect(res).to.deep.equal(expectedRes) + }); }) describe('userData', function () { From 003d444ae7d50ef725eec3ae4a7b2ee1b1fd057c Mon Sep 17 00:00:00 2001 From: Ahmad Lobany Date: Thu, 14 Jul 2022 13:45:30 +0300 Subject: [PATCH 2/3] ttl in getBid passing fix --- modules/taboolaBidAdapter.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/taboolaBidAdapter.js b/modules/taboolaBidAdapter.js index 32480f249..216392ae0 100644 --- a/modules/taboolaBidAdapter.js +++ b/modules/taboolaBidAdapter.js @@ -245,5 +245,4 @@ function getBid(requestId, currency, bidResponse) { netRevenue: false }; } - registerBidder(spec); From 42fe9d597b406441bb31d46ea05c1cc62be6ae90 Mon Sep 17 00:00:00 2001 From: Ahmad Lobany Date: Sun, 24 Jul 2022 15:29:25 +0300 Subject: [PATCH 3/3] [update-bid-response-ttl-passing] --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index c126c5d4a..8a024f8c1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6,7 +6,7 @@ "packages": { "": { "name": "prebid.js", - "version": "7.4.0-pre", + "version": "6.28.0-pre", "license": "Apache-2.0", "dependencies": { "@babel/core": "^7.16.7",