From 68b6c3aa6b430510b49f62994b577df31d9e1f87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 09:15:08 +0200 Subject: [PATCH 1/8] test-v8-patch --- .github/workflows/update-v8.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 3dc11797f853bf..33f78b3a52ea2e 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -44,13 +44,10 @@ jobs: - uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4 # Creates a PR or update the Action's existing PR, or # no-op if the base branch is already up-to-date. - env: - GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }} with: author: Node.js GitHub Bot body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}. branch: actions/update-v8-patch # Custom branch *just* for this Action. - commit-message: 'deps: patch V8 to ${{ env.NEW_VERSION }}' labels: v8 engine title: 'deps: patch V8 to ${{ env.NEW_VERSION }}' update-pull-request-title-and-body: true From 70f544aeaf0fb206a164ea4b1ca73a1ff9eaedf3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 09:16:44 +0200 Subject: [PATCH 2/8] dont skip --- .github/workflows/update-v8.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 33f78b3a52ea2e..2474bf2c2d9930 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -13,7 +13,6 @@ permissions: jobs: v8-update: - if: github.repository == 'nodejs/node' runs-on: ubuntu-latest steps: - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 From a757a47a508a9a542b5bf39109b02270a1dec100 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 10:12:49 +0200 Subject: [PATCH 3/8] github token --- .github/workflows/update-v8.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 2474bf2c2d9930..cbd069af7f6a48 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -43,6 +43,8 @@ jobs: - uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4 # Creates a PR or update the Action's existing PR, or # no-op if the base branch is already up-to-date. + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: author: Node.js GitHub Bot body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}. From 6a833ea462cded481a7e9f2febb820dcd127ff69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 10:17:46 +0200 Subject: [PATCH 4/8] remove author --- .github/workflows/update-v8.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index cbd069af7f6a48..01d3b3fd0cc98b 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -46,7 +46,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - author: Node.js GitHub Bot body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}. branch: actions/update-v8-patch # Custom branch *just* for this Action. labels: v8 engine From a9969a6f436d8344008ef8d2bf4e88155fcd506b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 10:31:34 +0200 Subject: [PATCH 5/8] add git user --- .github/workflows/update-v8.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 01d3b3fd0cc98b..35930a172619f8 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -34,6 +34,10 @@ jobs: node-version: ${{ env.NODE_VERSION }} - name: Install @node-core/utils run: npm install -g @node-core/utils + - name: Setup git config + run: | + git config --global user.name "Node.js GitHub Bot" + git config --global user.email "github-bot@iojs.org" - name: Check and download new V8 version run: | ./tools/dep_updaters/update-v8-patch.sh > temp-output From ac6e25bab2c03ae7ac631a645c7c6aa32035d39c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 11:08:54 +0200 Subject: [PATCH 6/8] try new action --- .github/workflows/update-v8.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 35930a172619f8..01f02613f742d6 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -44,14 +44,13 @@ jobs: cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output - - uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4 + - uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6.0.5 # Creates a PR or update the Action's existing PR, or # no-op if the base branch is already up-to-date. - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}. + token: ${{ secrets.GITHUB_TOKEN }} branch: actions/update-v8-patch # Custom branch *just* for this Action. - labels: v8 engine + delete-branch: true title: 'deps: patch V8 to ${{ env.NEW_VERSION }}' - update-pull-request-title-and-body: true + body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}. + labels: v8 engine From f812f8396421fd6f7e00b23c42121e5544c5b54c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sun, 12 May 2024 11:14:40 +0200 Subject: [PATCH 7/8] change token --- .github/workflows/update-v8.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-v8.yml b/.github/workflows/update-v8.yml index 01f02613f742d6..259f672cc8bffa 100644 --- a/.github/workflows/update-v8.yml +++ b/.github/workflows/update-v8.yml @@ -48,7 +48,7 @@ jobs: # Creates a PR or update the Action's existing PR, or # no-op if the base branch is already up-to-date. with: - token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ secrets.GH_USER_TOKEN }} branch: actions/update-v8-patch # Custom branch *just* for this Action. delete-branch: true title: 'deps: patch V8 to ${{ env.NEW_VERSION }}' From a3c4be5f32d14bd6840e78b724836060c771d616 Mon Sep 17 00:00:00 2001 From: "Node.js GitHub Bot" Date: Sun, 12 May 2024 09:15:52 +0000 Subject: [PATCH 8/8] deps: patch V8 to 12.4.254.16 Refs: https://github.com/v8/v8/compare/12.4.254.14...12.4.254.16 --- deps/v8/include/v8-version.h | 2 +- deps/v8/infra/testing/builders.pyl | 34 +++++++++++++++--------------- deps/v8/src/objects/js-objects.cc | 4 +--- 3 files changed, 19 insertions(+), 21 deletions(-) diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index f16596a58fa667..b026831a25cdd6 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 12 #define V8_MINOR_VERSION 4 #define V8_BUILD_NUMBER 254 -#define V8_PATCH_LEVEL 14 +#define V8_PATCH_LEVEL 16 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/infra/testing/builders.pyl b/deps/v8/infra/testing/builders.pyl index 2aca712ca73f8a..7655763cab411c 100644 --- a/deps/v8/infra/testing/builders.pyl +++ b/deps/v8/infra/testing/builders.pyl @@ -962,7 +962,7 @@ 'v8_mac64_asan_rel': { 'swarming_dimensions' : { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'v8testing', 'shards': 8}, @@ -971,7 +971,7 @@ 'v8_mac64_dbg': { 'swarming_dimensions' : { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'mozilla'}, @@ -984,7 +984,7 @@ 'v8_mac_arm64_gc_stress_dbg': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3}, @@ -993,7 +993,7 @@ 'v8_mac64_noopt_dbg': { 'swarming_dimensions' : { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'v8testing', 'shards': 6}, @@ -1002,7 +1002,7 @@ 'v8_mac64_rel': { 'swarming_dimensions' : { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'mozilla'}, @@ -1015,7 +1015,7 @@ 'v8_mac_arm64_rel': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', 'pool': 'chromium.tests', }, 'tests': [ @@ -1031,7 +1031,7 @@ 'v8_mac_arm64_dbg': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', 'pool': 'chromium.tests', }, 'tests': [ @@ -1047,7 +1047,7 @@ 'v8_mac_arm64_full_dbg': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', 'pool': 'chromium.tests', }, 'tests': [ @@ -1063,7 +1063,7 @@ 'v8_mac_arm64_no_pointer_compression_dbg': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', 'pool': 'chromium.tests', }, 'tests': [ @@ -1848,7 +1848,7 @@ 'V8 Mac64': { 'swarming_dimensions': { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'mozilla'}, @@ -1861,7 +1861,7 @@ 'V8 Mac64 - debug': { 'swarming_dimensions': { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'mozilla'}, @@ -1874,7 +1874,7 @@ 'V8 Mac64 ASAN': { 'swarming_dimensions': { 'cpu': 'x86-64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'v8testing', 'shards': 10}, @@ -1883,7 +1883,7 @@ 'V8 Mac - arm64 - gc stress': { 'swarming_dimensions': { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', }, 'tests': [ {'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3}, @@ -1891,7 +1891,7 @@ }, 'V8 Mac - arm64': { 'swarming_dimensions' : { - 'os': 'Mac-13', + 'os': 'Mac-14', 'cpu': 'arm64', 'pool': 'chromium.tests', }, @@ -1908,7 +1908,7 @@ }, 'V8 Mac - arm64 - release': { 'swarming_dimensions' : { - 'os': 'Mac-13', + 'os': 'Mac-14', 'cpu': 'arm64', 'pool': 'chromium.tests', }, @@ -1925,7 +1925,7 @@ }, 'V8 Mac - arm64 - debug': { 'swarming_dimensions' : { - 'os': 'Mac-13', + 'os': 'Mac-14', 'cpu': 'arm64', 'pool': 'chromium.tests', }, @@ -1943,7 +1943,7 @@ 'V8 Mac - arm64 - no pointer compression debug': { 'swarming_dimensions' : { 'cpu': 'arm64', - 'os': 'Mac-13', + 'os': 'Mac-14', 'pool': 'chromium.tests', }, 'tests': [ diff --git a/deps/v8/src/objects/js-objects.cc b/deps/v8/src/objects/js-objects.cc index e5a03dff14835e..2f3ab484cdc010 100644 --- a/deps/v8/src/objects/js-objects.cc +++ b/deps/v8/src/objects/js-objects.cc @@ -432,9 +432,7 @@ Maybe JSReceiver::SetOrCopyDataProperties( Nothing()); if (!from->HasFastProperties() && target->HasFastProperties() && - !IsJSGlobalProxy(*target)) { - // JSProxy is always in slow-mode. - DCHECK(!IsJSProxy(*target)); + IsJSObject(*target) && !IsJSGlobalProxy(*target)) { // Convert to slow properties if we're guaranteed to overflow the number of // descriptors. int source_length;