From 1e789a63a5c74b284293cf60a8cc366e51ef01e5 Mon Sep 17 00:00:00 2001 From: Teodora Jovcheska Date: Fri, 12 Apr 2024 11:53:11 +0200 Subject: [PATCH 1/2] Validate that screenshot has valid .png extension --- src/main/java/testUI/elements/Element.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/testUI/elements/Element.java b/src/main/java/testUI/elements/Element.java index 7af6aaf..dd5b975 100644 --- a/src/main/java/testUI/elements/Element.java +++ b/src/main/java/testUI/elements/Element.java @@ -817,8 +817,12 @@ public Asserts should() { return shouldHave(); } - public UIElement saveScreenshot(String path) { + if (!path.toLowerCase().endsWith(".png")) { + Logger.putLogError("Invalid file extension. Only .png files are supported for screenshots."); + return null; + } + if (!Configuration.automationType.equals(Configuration.DESKTOP_PLATFORM)) { if (getDrivers().size() != 0) { Configuration.driver = Math.min(Configuration.driver, getDrivers().size()); From 4d23c62a4a8cca76de4072617296d008a8cf8ab6 Mon Sep 17 00:00:00 2001 From: Teodora Jovcheska Date: Tue, 2 Jul 2024 17:05:10 +0200 Subject: [PATCH 2/2] Log the screenshot path --- src/main/java/testUI/elements/Element.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/testUI/elements/Element.java b/src/main/java/testUI/elements/Element.java index dd5b975..33ca149 100644 --- a/src/main/java/testUI/elements/Element.java +++ b/src/main/java/testUI/elements/Element.java @@ -819,8 +819,8 @@ public Asserts should() { public UIElement saveScreenshot(String path) { if (!path.toLowerCase().endsWith(".png")) { - Logger.putLogError("Invalid file extension. Only .png files are supported for screenshots."); - return null; + Logger.putLogWarn("Invalid file extension: Only .png files are supported. Screenshot saved in: "+ Configuration.screenshotPath + path); + return getElementObject(); } if (!Configuration.automationType.equals(Configuration.DESKTOP_PLATFORM)) {