ASoC: topology: Add support for WO and RO TLV byte kcontrols

Dharageswari R · plbossart · commit 38d7853084d0 · 2020-08-27T10:14:22.000-05:00
This patch adds support for write-only and read-only TLV byte kcontrols
by checking for appropriate get/put IO handlers.

Signed-off-by: Dharageswari R &lt;dharageswari.r@intel.com&gt;
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
@@ -603,10 +603,11 @@ static int soc_tplg_kcontrol_bind_io(struct snd_soc_tplg_ctl_hdr *hdr,
 				sbe->get = ext_ops[i].get;
 		}
 
-		if (sbe->put && sbe->get)
-			return 0;
-		else
+		if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ) && !sbe->get)
 			return -EINVAL;
+		if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && !sbe->put)
+			return -EINVAL;
+		return 0;
 	}
 
 	/* try and map vendor specific kcontrol handlers first */

Original file line number	Diff line number	Diff line change
`@@ -603,10 +603,11 @@ static int soc_tplg_kcontrol_bind_io(struct snd_soc_tplg_ctl_hdr *hdr,`
`603`	`603`	`sbe->get = ext_ops[i].get;`
`604`	`604`	`}`
`605`	`605`
`606`		`- if (sbe->put && sbe->get)`
`607`		`- return 0;`
`608`		`- else`
	`606`	`+ if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ) && !sbe->get)`
`609`	`607`	`return -EINVAL;`
	`608`	`+ if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && !sbe->put)`
	`609`	`+ return -EINVAL;`
	`610`	`+ return 0;`
`610`	`611`	`}`
`611`	`612`
`612`	`613`	`/* try and map vendor specific kcontrol handlers first */`