Skip to content

Commit 68b7676

Browse files
committed
fixup! ASoC: SOF: IPC4: set the BE DAI ops
naming and comment clarification to highlight differences between IPC3 and IPC4 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent d811f9f commit 68b7676

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

sound/soc/sof/intel/hda-dai.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,8 +450,12 @@ static int ipc3_hda_dai_trigger(struct snd_pcm_substream *substream,
450450
return 0;
451451
}
452452

453-
static int ipc4_hda_link_dma_trigger(struct snd_pcm_substream *substream,
454-
int cmd, struct snd_soc_dai *dai)
453+
/*
454+
* In contrast to IPC3, the dai trigger in IPC4 mixes pipeline state changes
455+
* (over IPC channel) and DMA state change (direct host register changes).
456+
*/
457+
static int ipc4_hda_dai_trigger(struct snd_pcm_substream *substream,
458+
int cmd, struct snd_soc_dai *dai)
455459
{
456460
struct hdac_ext_stream *hext_stream = snd_soc_dai_get_dma_data(dai, substream);
457461
struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
@@ -591,7 +595,7 @@ static int hda_dai_suspend(struct hdac_bus *bus)
591595
static const struct snd_soc_dai_ops ipc4_hda_dai_ops = {
592596
.hw_params = hda_dai_hw_params,
593597
.hw_free = hda_dai_hw_free,
594-
.trigger = ipc4_hda_link_dma_trigger,
598+
.trigger = ipc4_hda_dai_trigger,
595599
.prepare = hda_dai_prepare,
596600
};
597601

0 commit comments

Comments
 (0)