Skip to content

Commit 7df28fa

Browse files
committed
ASoC: SOF: loader: don't use devm_kasprintf for fw_filename
The name is not persistent and use once, just use kasprintf and free Feedback from Takashi Iwai Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent 0d77d1c commit 7df28fa

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

sound/soc/sof/loader.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,9 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev)
260260
if (plat_data->fw)
261261
return 0;
262262

263-
fw_filename = devm_kasprintf(sdev->dev, GFP_KERNEL,
264-
"%s/%s",
265-
plat_data->fw_filename_prefix,
266-
plat_data->fw_filename);
263+
fw_filename = kasprintf(GFP_KERNEL, "%s/%s",
264+
plat_data->fw_filename_prefix,
265+
plat_data->fw_filename);
267266
if (!fw_filename)
268267
return -ENOMEM;
269268

@@ -273,6 +272,9 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev)
273272
dev_err(sdev->dev, "error: request firmware %s failed err: %d\n",
274273
fw_filename, ret);
275274
}
275+
276+
kfree(fw_filename);
277+
276278
return ret;
277279
}
278280
EXPORT_SYMBOL(snd_sof_load_firmware_raw);

0 commit comments

Comments
 (0)