From 7df28fa37ea9f97d1de049259bfc2f9f66ece036 Mon Sep 17 00:00:00 2001 From: Pierre-Louis Bossart Date: Thu, 11 Apr 2019 17:34:44 -0500 Subject: [PATCH] ASoC: SOF: loader: don't use devm_kasprintf for fw_filename The name is not persistent and use once, just use kasprintf and free Feedback from Takashi Iwai Signed-off-by: Pierre-Louis Bossart --- sound/soc/sof/loader.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c index e73314ccd54ffb..81c7452aae1718 100644 --- a/sound/soc/sof/loader.c +++ b/sound/soc/sof/loader.c @@ -260,10 +260,9 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev) if (plat_data->fw) return 0; - fw_filename = devm_kasprintf(sdev->dev, GFP_KERNEL, - "%s/%s", - plat_data->fw_filename_prefix, - plat_data->fw_filename); + fw_filename = kasprintf(GFP_KERNEL, "%s/%s", + plat_data->fw_filename_prefix, + plat_data->fw_filename); if (!fw_filename) return -ENOMEM; @@ -273,6 +272,9 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev) dev_err(sdev->dev, "error: request firmware %s failed err: %d\n", fw_filename, ret); } + + kfree(fw_filename); + return ret; } EXPORT_SYMBOL(snd_sof_load_firmware_raw);