From dc580c5bb092492a8a8fc1f1bad6e865f3605f9d Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Fri, 30 Jun 2023 17:58:05 -0700 Subject: [PATCH 1/2] lib.sh: warn about HTML bug hiding zephyr log levels Internal Intel issue 448. Signed-off-by: Marc Herbert --- case-lib/lib.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/case-lib/lib.sh b/case-lib/lib.sh index 2db58f79..e384eb16 100644 --- a/case-lib/lib.sh +++ b/case-lib/lib.sh @@ -529,7 +529,10 @@ check_error_in_fw_logfile() if (set -x grep -B 2 -A 1 -i --word-regexp -e 'ERR' -e 'ERROR' -e '' "$1" ); then - return 1 + # See internal Intel bug #448 + dlogw 'An HTML display bug hides the bracketed Zephyr <loglevels> in this tab,' + dlogw 'switch to the tab with the complete logs to see the log levels.' + return 1 fi } From 282565249653d79a26deadee8af009a8b8be2a86 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Thu, 29 Jun 2023 19:42:11 -0700 Subject: [PATCH 2/2] hijack.sh: fail when an error is found in Zephyr firmware logs At last. Signed-off-by: Marc Herbert --- case-lib/hijack.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/case-lib/hijack.sh b/case-lib/hijack.sh index a489f982..8175f119 100644 --- a/case-lib/hijack.sh +++ b/case-lib/hijack.sh @@ -110,6 +110,18 @@ function func_exit_handler() dloge "Empty logfile" exit_status=1 fi + + # We still have some false positives in stable-v2.2 for now, see + # https://github.com/thesofproject/sof-test/pull/1075 + # https://github.com/thesofproject/sof/pull/9036 + # etc. + if is_firmware_file_zephyr; then + + check_error_in_fw_logfile "$logfile" || + exit_status=1 + + fi + else dloge "Log file not found: $logfile" exit_status=1