diff --git a/test-case/check-sof-logger.sh b/test-case/check-sof-logger.sh index 037e0bbd..77f86dd4 100755 --- a/test-case/check-sof-logger.sh +++ b/test-case/check-sof-logger.sh @@ -25,16 +25,16 @@ func_opt_parse_option "$@" setup_kernel_check_point # check sof-logger location -if [ -z $(which sof-logger) ]; then +type -a sof-logger || die "sof-logger Not Installed!" -fi -if [ $(which -a sof-logger|wc -l) -ne 1 ]; then + +if type -a sof-logger | tail -n +2 | grep -q . ; then dlogw "There are multiple sof-loggers in system" - dlogw "using " `which sof-logger` + dlogw "using $(type -p sof-logger)" fi -loggerBin=$(which sof-logger) -dlogi "Found file: $(md5sum $loggerBin|awk '{print $2, $1;}')" +loggerBin=$(type -p sof-logger) +dlogi "Found file: $(md5sum "$loggerBin" | awk '{print $2, $1;}')" dlogi "Looking for ldc File ..." ldcFile=$(find_ldc_file) || die ".ldc file not found!" @@ -51,20 +51,20 @@ dlogi "Try to dump the dma trace log via sof-logger ..." dlogc "sudo $loggerBin -t -l $ldcFile -o $data_file 2> $error_file &" sudo bash -c "'$loggerBin -t -l $ldcFile -o $data_file 2> $error_file &'" sleep 2 -dlogc "sudo pkill -9 $(basename $loggerBin)" -sudo pkill -9 $(basename $loggerBin) 2> /dev/null +dlogc "sudo pkill -9 $(basename "$loggerBin")" +sudo pkill -9 "$(basename "$loggerBin")" 2> /dev/null func_logger_exit() { local code=$1 type=${2:-data} dlogi "Log $type BEG>>" - cat $LOG_ROOT/logger.$type.log + cat "$LOG_ROOT/logger.$type.log" dlogi "<