diff --git a/test-case/check-suspend-resume.sh b/test-case/check-suspend-resume.sh index f0c1409e..edce695f 100755 --- a/test-case/check-suspend-resume.sh +++ b/test-case/check-suspend-resume.sh @@ -19,7 +19,8 @@ set -e ## check kernel log and find no errors ## -source $(dirname ${BASH_SOURCE[0]})/../case-lib/lib.sh +# shellcheck source=case-lib/lib.sh +source "$(dirname "${BASH_SOURCE[0]}")"/../case-lib/lib.sh random_min=3 # wait time should >= 3 for other device wakeup from sleep random_max=20 @@ -46,9 +47,12 @@ type=${OPT_VAL['T']} # switch type if [ "$type" ]; then # check for type value effect - [[ ! "$(cat /sys/power/mem_sleep|grep $type)" ]] && dloge "useless type option" && exit 2 - dlogc "sudo bash -c 'echo $type > /sys/power/mem_sleep'" - sudo bash -c "'echo $type > /sys/power/mem_sleep'" + grep -q "$type" /sys/power/mem_sleep || { + grep -H '^' /sys/power/mem_sleep + die "Unsupported sleep type argument: $type" + } + dlogc "echo $type > /sys/power/mem_sleep" + echo "$type" | >/dev/null sudo tee -a /sys/power/mem_sleep fi dlogi "Current suspend/resume type mode: $(cat /sys/power/mem_sleep)" @@ -82,8 +86,8 @@ do setup_kernel_check_point sleep_count=$(cat /sys/power/wakeup_count) dlogc "Run the command: rtcwake -m mem -s ${sleep_lst[$i]}" - sudo rtcwake -m mem -s ${sleep_lst[$i]} - [[ $? -ne 0 ]] && die "rtcwake return value error" + sudo rtcwake -m mem -s "${sleep_lst[$i]}" || + die "rtcwake returned $?" dlogc "sleep for ${wait_lst[$i]}" sleep ${wait_lst[$i]} dlogi "Check for the kernel log status"