ipc: Fix false positive IPC dropped messages.

On receiving an IPC IRQ the handler currently does not check the
IRQ mask. This means notification received ACKs (i.e. for trace updates)
from the host may be reported as duplicate host command IPCs.

Fix this by checking IPC IRQ mask.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Author: lrgirdwo

src/ipc/apl-ipc.c

@@ -59,18 +59,21 @@ static void irq_handler(void *arg)
 {
 	uint32_t dipct;
 	uint32_t dipcie;
+	uint32_t dipcctl;
 	uint32_t msg = 0;
 
 	dipct = ipc_read(IPC_DIPCT);
 	dipcie = ipc_read(IPC_DIPCIE);
+	dipcctl = ipc_read(IPC_DIPCCTL);
 
-	tracev_ipc("ipc: irq dipct 0x%x dipcie 0x%x", dipct, dipcie);
+	tracev_ipc("ipc: irq dipct 0x%x dipcie 0x%x dipcctl 0x%x", dipct,
+		   dipcie, dipcctl);
 
 	/* new message from host */
-	if (dipct & IPC_DIPCT_BUSY) {
+	if (dipct & IPC_DIPCT_BUSY && dipcctl & IPC_DIPCCTL_IPCTBIE) {
 
 		/* mask Busy interrupt */
-		ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) & ~IPC_DIPCCTL_IPCTBIE);
+		ipc_write(IPC_DIPCCTL, dipcctl & ~IPC_DIPCCTL_IPCTBIE);
 
 		msg = dipct & IPC_DIPCT_MSG_MASK;
 

src/ipc/cnl-ipc.c

@@ -60,18 +60,21 @@ static void irq_handler(void *arg)
 {
 	uint32_t dipctdr;
 	uint32_t dipcida;
+	uint32_t dipcctl;
 	uint32_t msg = 0;
 
 	dipctdr = ipc_read(IPC_DIPCTDR);
 	dipcida = ipc_read(IPC_DIPCIDA);
+	dipcctl = ipc_read(IPC_DIPCCTL);
 
-	tracev_ipc("ipc: irq dipctdr 0x%x dipcida 0x%x", dipctdr, dipcida);
+	tracev_ipc("ipc: irq dipct 0x%x dipcie 0x%x dipcctl 0x%x", dipct,
+		   dipcie, dipcctl);
 
 	/* new message from host */
-	if (dipctdr & IPC_DIPCTDR_BUSY) {
+	if (dipctdr & IPC_DIPCTDR_BUSY && dipcctl & IPC_DIPCCTL_IPCTBIE) {
 
 		/* mask Busy interrupt */
-		ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) & ~IPC_DIPCCTL_IPCTBIE);
+		ipc_write(IPC_DIPCCTL, dipcctl & ~IPC_DIPCCTL_IPCTBIE);
 
 		msg = dipctdr & IPC_DIPCTDR_MSG_MASK;