Skip to content

Commit 21e2028

Browse files
marc-hbkv2019i
authored andcommitted
tools/plugin: drop bogus -Wl,-EL binutils endianness option
This mysterious option has been causing portability issues and has never made any difference, see previous commits for details. I compiled the plugin with and without it and there was absolutely zero binary difference. Let's remove it from all tools/plugin/ CMakeLists.txt files before the mass copy/paste/diverge there spreads it even more. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent dc90583 commit 21e2028

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

tools/plugin/alsaplug/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ target_include_directories(asound_module_pcm_sof PRIVATE
1515
${CMAKE_CURRENT_SOURCE_DIR}/..
1616
${sof_source_directory}/src/audio)
1717

18-
target_compile_options(asound_module_pcm_sof PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
18+
target_compile_options(asound_module_pcm_sof PRIVATE -DPIC -g -O3 -Wmissing-prototypes
1919
-Wimplicit-fallthrough -DCONFIG_LIBRARY -imacros${config_h})
2020

2121
install(TARGETS asound_module_pcm_sof DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
@@ -47,7 +47,7 @@ target_include_directories(asound_module_ctl_sof PRIVATE
4747
${CMAKE_CURRENT_SOURCE_DIR}/..
4848
${sof_source_directory}/src/audio)
4949

50-
target_compile_options(asound_module_ctl_sof PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
50+
target_compile_options(asound_module_ctl_sof PRIVATE -DPIC -g -O3 -Wmissing-prototypes
5151
-Wimplicit-fallthrough -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
5252

5353
install(TARGETS asound_module_ctl_sof DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)

tools/plugin/modules/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ target_include_directories(sof_mod_shm PRIVATE
1111
${CMAKE_CURRENT_SOURCE_DIR}/../pipe
1212
${sof_source_directory}/src/audio)
1313

14-
target_compile_options(sof_mod_shm PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
14+
target_compile_options(sof_mod_shm PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
1515

1616
install(TARGETS sof_mod_shm
1717
DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
@@ -39,7 +39,7 @@ target_include_directories(sof_mod_alsa PRIVATE
3939
${CMAKE_CURRENT_SOURCE_DIR}/../pipe
4040
${sof_source_directory}/src/audio)
4141

42-
target_compile_options(sof_mod_alsa PRIVATE -DPIC -g -O3 -Wl,-EL -Wmissing-prototypes
42+
target_compile_options(sof_mod_alsa PRIVATE -DPIC -g -O3 -Wmissing-prototypes
4343
-Wimplicit-fallthrough -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
4444

4545
install(TARGETS sof_mod_alsa

tools/plugin/modules/ov_noise_suppression/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ add_library(sof_ns MODULE noise_suppression.c)
2020
target_link_libraries(sof_ns PRIVATE sof_ns_interface)
2121
target_link_libraries(sof_ns PRIVATE -Wl,--export-dynamic)
2222
sof_append_relative_path_definitions(sof_ns)
23-
target_compile_options(sof_ns PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
23+
target_compile_options(sof_ns PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
2424
install(TARGETS sof_ns DESTINATION /usr/lib/x86_64-linux-gnu/alsa-lib)
2525

2626
target_include_directories(sof_ns PRIVATE

tools/plugin/pipe/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ target_include_directories(sof-pipe PRIVATE
1616
${CMAKE_CURRENT_SOURCE_DIR}/..
1717
${sof_source_directory}/src/audio)
1818

19-
target_compile_options(sof-pipe PRIVATE -DPIC -g -O3 -Wl,-EL -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
19+
target_compile_options(sof-pipe PRIVATE -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros${config_h})
2020

2121
target_include_directories(sof-pipe PRIVATE ${sof_install_directory}/include)
2222
target_include_directories(sof-pipe PRIVATE ${parser_install_dir}/include)

0 commit comments

Comments
 (0)