ipc_platform_send_msg: Replace goto with return.

Replaced assigning an error code to the ret variable and goto error with
return error code.

Signed-off-by: Adrian Warecki <adrianx.warecki@intel.com>

Author: Adrian Warecki

src/drivers/amd/renoir/ipc.c

@@ -168,7 +168,6 @@ void ipc_platform_complete_cmd(struct ipc *ipc)
 
 int ipc_platform_send_msg(const struct ipc_msg *msg)
 {
-	int ret = 0;
 	acp_sw_intr_trig_t  sw_intr_trig;
 	acp_dsp_sw_intr_stat_t sw_intr_stat;
 	uint32_t status;
@@ -182,20 +181,17 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 		sw_intr_stat = (acp_dsp_sw_intr_stat_t)
 				io_reg_read(PU_REGISTER_BASE + ACP_DSP_SW_INTR_STAT);
 		status =  sw_intr_stat.bits.dsp0_to_host_intr_stat;
-		ret = -EBUSY;
-		goto out;
+		return -EBUSY;
 	}
 	lock = io_reg_read(PU_REGISTER_BASE + ACP_AXI2DAGB_SEM_0);
 	while (lock) {
 		lock = io_reg_read(PU_REGISTER_BASE + ACP_AXI2DAGB_SEM_0);
-		if (!delay_cnt) {
-			ret = -EBUSY;
-			break;
-		}
+		if (!delay_cnt)
+			return -EBUSY;
+
 		delay_cnt--;
 	}
-	if (ret)
-		goto out;
+
 	/* Write new message in the mailbox */
 	mailbox_dspbox_write(0, msg->tx_data, msg->tx_size);
 
@@ -208,8 +204,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 	sw_intr_trig.bits.trig_dsp0_to_host_intr = INTERRUPT_DISABLE;
 	io_reg_write((PU_REGISTER_BASE + ACP_SW_INTR_TRIG), sw_intr_trig.u32all);
 	io_reg_write((PU_REGISTER_BASE + ACP_AXI2DAGB_SEM_0), lock);
-out:
-	return ret;
+	return 0;
 }
 
 int platform_ipc_init(struct ipc *ipc)

src/drivers/imx/ipc.c

@@ -126,13 +126,11 @@ void ipc_platform_complete_cmd(struct ipc *ipc)
 int ipc_platform_send_msg(const struct ipc_msg *msg)
 {
 	struct ipc *ipc = ipc_get();
-	int ret = 0;
 
 	/* can't send notification when one is in progress */
 	if (ipc->is_notification_pending ||
 	    imx_mu_read(IMX_MU_xCR(IMX_MU_VERSION, IMX_MU_GCR)) & IMX_MU_xCR_GIRn(IMX_MU_VERSION, 1)) {
-		ret = -EBUSY;
-		goto out;
+		return -EBUSY;
 	}
 
 	/* now send the message */
@@ -144,10 +142,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 
 	/* now interrupt host to tell it we have sent a message */
 	imx_mu_xcr_rmw(IMX_MU_VERSION, IMX_MU_GCR, IMX_MU_xCR_GIRn(IMX_MU_VERSION, 1), 0);
-
-out:
-
-	return ret;
+	return 0;
 }
 
 #if CONFIG_HOST_PTABLE

src/drivers/intel/baytrail/ipc.c

@@ -114,13 +114,11 @@ void ipc_platform_complete_cmd(struct ipc *ipc)
 int ipc_platform_send_msg(const struct ipc_msg *msg)
 {
 	struct ipc *ipc = ipc_get();
-	int ret = 0;
 
 	/* can't send notification when one is in progress */
 	if (ipc->is_notification_pending ||
 	    shim_read(SHIM_IPCDH) & (SHIM_IPCDH_BUSY | SHIM_IPCDH_DONE)) {
-		ret = -EBUSY;
-		goto out;
+		return -EBUSY;
 	}
 
 	/* now send the message */
@@ -133,10 +131,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 	/* now interrupt host to tell it we have message sent */
 	shim_write(SHIM_IPCDL, msg->header);
 	shim_write(SHIM_IPCDH, SHIM_IPCDH_BUSY);
-
-out:
-
-	return ret;
+	return 0;
 }
 
 struct ipc_data_host_buffer *ipc_platform_get_host_buffer(struct ipc *ipc)

src/drivers/intel/cavs/ipc.c

@@ -218,7 +218,6 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 {
 	struct ipc *ipc = ipc_get();
 	ipc_cmd_hdr *hdr;
-	int ret = 0;
 
 	if (ipc->is_notification_pending ||
 #if CAVS_VERSION == CAVS_VERSION_1_5
@@ -227,8 +226,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 	    ipc_read(IPC_DIPCIDR) & IPC_DIPCIDR_BUSY ||
 	    ipc_read(IPC_DIPCIDA) & IPC_DIPCIDA_DONE) {
 #endif
-		ret = -EBUSY;
-		goto out;
+		return -EBUSY;
 	}
 
 	tr_dbg(&ipc_tr, "ipc: msg tx -> 0x%x", msg->header);
@@ -247,8 +245,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 	ipc_write(IPC_DIPCIDR, IPC_DIPCIDR_BUSY | hdr[0]);
 #endif
 
-out:
-	return ret;
+	return 0;
 }
 
 int platform_ipc_init(struct ipc *ipc)

src/drivers/intel/haswell/ipc.c

@@ -116,13 +116,11 @@ void ipc_platform_complete_cmd(struct ipc *ipc)
 int ipc_platform_send_msg(const struct ipc_msg *msg)
 {
 	struct ipc *ipc = ipc_get();
-	int ret = 0;
 
 	/* can't send nofication when one is in progress */
 	if (ipc->is_notification_pending ||
 	    shim_read(SHIM_IPCD) & (SHIM_IPCD_BUSY | SHIM_IPCD_DONE)) {
-		ret = -EBUSY;
-		goto out;
+		return -EBUSY;
 	}
 
 	/* now send the message */
@@ -135,9 +133,7 @@ int ipc_platform_send_msg(const struct ipc_msg *msg)
 	/* now interrupt host to tell it we have message sent */
 	shim_write(SHIM_IPCD, SHIM_IPCD_BUSY);
 
-out:
-
-	return ret;
+	return 0;
 }
 
 struct ipc_data_host_buffer *ipc_platform_get_host_buffer(struct ipc *ipc)