Skip to content

Commit a8fcde6

Browse files
committed
Simplifies environment variable handling in build script
Replaces redundant `--env` flags with inline environment variable declarations in build script commands to improve readability and maintainability. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
1 parent e64ac4d commit a8fcde6

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

.github/workflows/testbench.yml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,17 @@ jobs:
5353
- name: build test topologies
5454
continue-on-error: true
5555
run: |
56-
./scripts/docker-run.sh \
57-
--env SOF_WORKSPACE=/home/sof/work/sof.git \
58-
--env PATH=/home/sof/work/sof.git/tools/bin:$PATH \
59-
--env PKG_CONFIG_PATH=/home/sof/work/sof.git/tools/lib/pkgconfig:$PKG_CONFIG_PATH \
60-
--env LD_LIBRARY_PATH=/home/sof/work/sof.git/tools/lib:$LD_LIBRARY_PATH \
61-
./scripts/build-tools.sh -A -Y ||
56+
env SOF_WORKSPACE=/home/sof/work/sof.git \
57+
PATH=/home/sof/work/sof.git/tools/bin:$PATH \
58+
PKG_CONFIG_PATH=/home/sof/work/sof.git/tools/lib/pkgconfig:$PKG_CONFIG_PATH \
59+
LD_LIBRARY_PATH=/home/sof/work/sof.git/tools/lib:$LD_LIBRARY_PATH \
60+
./scripts/docker-run.sh ./scripts/build-tools.sh -A -Y ||
6261
VERBOSE=1 NO_PROCESSORS=1 USE_XARGS=no \
63-
./scripts/docker-run.sh \
64-
--env SOF_WORKSPACE=/home/sof/work/sof.git \
65-
--env PATH=/home/sof/work/sof.git/tools/bin:$PATH \
66-
--env PKG_CONFIG_PATH=/home/sof/work/sof.git/tools/lib/pkgconfig:$PKG_CONFIG_PATH \
67-
--env LD_LIBRARY_PATH=/home/sof/work/sof.git/tools/lib:$LD_LIBRARY_PATH \
68-
./scripts/build-tools.sh -A -Y
62+
env SOF_WORKSPACE=/home/sof/work/sof.git \
63+
PATH=/home/sof/work/sof.git/tools/bin:$PATH \
64+
PKG_CONFIG_PATH=/home/sof/work/sof.git/tools/lib/pkgconfig:$PKG_CONFIG_PATH \
65+
LD_LIBRARY_PATH=/home/sof/work/sof.git/tools/lib:$LD_LIBRARY_PATH \
66+
./scripts/docker-run.sh ./scripts/build-tools.sh -A -Y
6967
7068
# Verify alsatplg version
7169
- name: verify alsatplg version

0 commit comments

Comments
 (0)