Skip to content

Commit ac3abc5

Browse files
Amery Songkv2019i
authored andcommitted
ASoC: SOF: Intel: hda: remove unnecessary ROM IPC filter function
The HDA_DSP_IPC_PURGE_FW IPC from ROM is already handled in cl_dsp_init(), and as IPC IRQ is disabled at this stage, this IPC will be never received in the IRQ thread. The function hda_dsp_ipc_is_sof for filtering the ROM IPC can be removed safely. Signed-off-by: Amery Song <chao.song@intel.com>
1 parent 557d3cd commit ac3abc5

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

sound/soc/sof/intel/hda-ipc.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,6 @@ void hda_dsp_ipc_get_reply(struct snd_sof_dev *sdev)
125125

126126
}
127127

128-
static bool hda_dsp_ipc_is_sof(uint32_t msg)
129-
{
130-
return (msg & (HDA_DSP_IPC_PURGE_FW | 0xf << 9)) != msg ||
131-
(msg & HDA_DSP_IPC_PURGE_FW) != HDA_DSP_IPC_PURGE_FW;
132-
}
133-
134128
/* IPC handler thread */
135129
irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context)
136130
{
@@ -176,11 +170,9 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context)
176170
*/
177171
spin_lock_irq(&sdev->ipc_lock);
178172

179-
/* handle immediate reply from DSP core - ignore ROM messages */
180-
if (hda_dsp_ipc_is_sof(msg)) {
181-
hda_dsp_ipc_get_reply(sdev);
182-
snd_sof_ipc_reply(sdev, msg);
183-
}
173+
/* handle immediate reply from DSP core */
174+
hda_dsp_ipc_get_reply(sdev);
175+
snd_sof_ipc_reply(sdev, msg);
184176

185177
/* wake up sleeper if we are loading code */
186178
if (sdev->code_loading) {

0 commit comments

Comments
 (0)