Skip to content

Commit ba001cb

Browse files
committed
app: board: Set CONFIG_VOLUME_HIFI3=y for MTL platform
Changed VOLUME_HIFI4 to VOLUME_HIFI3 on the MTL platform. There was a problem with test test_01_09_peakvol_quality[44100Hz_16in16bit_1ch-0]. The main problem was with frequencies: 11025, 22050, 44100, 88200, 176400 Hz. Because frame is different for these frequencies. For f=44100Hz frame is equal 44 or 45. Some of the samples were simply not processed. Changes to HIFI4 are not-trivial and failed to fix the problem. However, HIFI3 is fully compatible and works properly. Performance is worse by 1-2,5% in CPU cycle usage but no glitches appear and all samples are processed correctly. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
1 parent ae4f314 commit ba001cb

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/audio/volume/volume_hifi3_with_peakvol.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ LOG_MODULE_DECLARE(volume_hifi3, CONFIG_SOF_LOG_LEVEL);
2121

2222
#include "volume.h"
2323

24-
#if SOF_USE_HIFI(3, VOLUME)
24+
// Hifi4 is disabled, see bug https://github.com/thesofproject/sof/issues/9213
25+
// Hifi5 is not there yet.
26+
#if SOF_USE_HIFI(3, VOLUME) || SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
2527

2628
#if CONFIG_COMP_PEAK_VOL
2729

src/audio/volume/volume_hifi4_with_peakvol.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ LOG_MODULE_DECLARE(volume_hifi4, CONFIG_SOF_LOG_LEVEL);
2121

2222
#include "volume.h"
2323

24-
#if SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
24+
// disabled and replaced by HIFI3, see issue https://github.com/thesofproject/sof/issues/9213
25+
#if 0 // SOF_USE_HIFI(4, VOLUME) || SOF_USE_HIFI(5, VOLUME)
2526

2627
#if CONFIG_COMP_PEAK_VOL
2728
#include <xtensa/tie/xt_hifi4.h>

0 commit comments

Comments
 (0)