cmake: drop binutils-specific '-Wl,-EL' option

marc-hb · lgirdwood · commit bcbcec79e582 · 2021-10-26T20:13:55.000+01:00
Fixes clang failure: clang: error: -Wl,-EL: 'linker' input unused [-Werror,-Wunused-command-line-argument] -EL has an effect only when using OUTPUT_FORMAT or --oformat but rimage uses neither. The binaries produced by ld version 2.34 are strictly identical before and after this removal. It is not clear why -EL was ever added. It was added to src/Makefile.am by commit 0d33e87 and to src/CMakeLists.txt by commit 4e3ead0 but these commits were initial additions of the entire files and they did not get into detail. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -25,7 +25,7 @@ add_executable(rimage
 )
 
 target_compile_options(rimage PRIVATE
-	-Wall -Werror -Wl,-EL -Wmissing-prototypes -Wimplicit-fallthrough
+	-Wall -Werror -Wmissing-prototypes -Wimplicit-fallthrough
 )
 
 target_link_libraries(rimage PRIVATE "-lcrypto")

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ add_executable(rimage`
`25`	`25`	`)`
`26`	`26`
`27`	`27`	`target_compile_options(rimage PRIVATE`
`28`		`- -Wall -Werror -Wl,-EL -Wmissing-prototypes -Wimplicit-fallthrough`
	`28`	`+ -Wall -Werror -Wmissing-prototypes -Wimplicit-fallthrough`
`29`	`29`	`)`
`30`	`30`
`31`	`31`	`target_link_libraries(rimage PRIVATE "-lcrypto")`