dma: Implement DMA IRQ callback using notifier interface.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>

Author: akloniex

src/drivers/dw/dma.c

@@ -761,9 +761,11 @@ static int dw_dma_pm_context_store(struct dma *dma)
 }
 
 #if !CONFIG_HW_LLI
-/* reload using LLI data */
-static inline void dw_dma_chan_reload_lli(struct dma_chan_data *channel)
+/* reload using LLI data from DMA IRQ cb */
+static inline void dw_dma_chan_reload_lli_cb(void *arg, enum notify_id type,
+					     void *data)
 {
+	struct dma_chan_data *channel = data;
 	struct dma *dma = channel->dma;
 	struct dw_dma_chan_data *dw_chan = dma_chan_get_data(channel);
 	struct dw_lli *lli = dw_chan->lli_current;
@@ -967,7 +969,8 @@ static int dw_dma_probe(struct dma *dma)
 		chan->index = i;
 		chan->core = DMA_CORE_INVALID;
 #if !CONFIG_HW_LLI
-		chan->irq_callback = dw_dma_chan_reload_lli;
+		notifier_register(chan, chan, NOTIFIER_ID_DMA_IRQ,
+				  dw_dma_chan_reload_lli_cb);
 #endif
 
 		dw_chan = rzalloc(RZONE_SYS_RUNTIME | RZONE_FLAG_UNCACHED,

src/include/sof/lib/dma.h

@@ -211,11 +211,6 @@ struct dma_chan_data {
 	/* true if this DMA channel is the scheduling source */
 	bool is_scheduling_source;
 
-	/* called by the DMA domain right after receiving an interrupt,
-	 * so should execute very time-sensitive operations
-	 */
-	void (*irq_callback)(struct dma_chan_data *channel);
-
 	void *private;
 };
 

src/include/sof/lib/notifier.h

@@ -28,6 +28,7 @@ enum notify_id {
 	NOTIFIER_ID_BUFFER_CONSUME,		/* struct buffer_cb_transact* */
 	NOTIFIER_ID_BUFFER_FREE,		/* struct buffer_cb_free* */
 	NOTIFIER_ID_DMA_COPY,			/* struct dma_cb_data* */
+	NOTIFIER_ID_DMA_IRQ,			/* struct dma_chan_data * */
 	NOTIFIER_ID_COUNT
 };
 

src/schedule/dma_multi_chan_domain.c

@@ -11,6 +11,7 @@
 #include <sof/lib/alloc.h>
 #include <sof/lib/cpu.h>
 #include <sof/lib/dma.h>
+#include <sof/lib/notifier.h>
 #include <sof/platform.h>
 #include <sof/schedule/ll_schedule.h>
 #include <sof/schedule/ll_schedule_domain.h>
@@ -272,9 +273,10 @@ static bool dma_multi_chan_domain_is_pending(struct ll_schedule_domain *domain,
 			    platform_timer_get(platform_timer))
 				continue;
 
-			/* execute callback if exists */
-			if (dmas[i].chan[j].irq_callback)
-				dmas[i].chan[j].irq_callback(&dmas[i].chan[j]);
+			notifier_event(&dmas[i].chan[j], NOTIFIER_ID_DMA_IRQ,
+				       NOTIFIER_TARGET_CORE_LOCAL,
+				       &dmas[i].chan[j],
+				       sizeof(struct dma_chan_data));
 
 			/* clear interrupt */
 			if (pipe_task->registrable) {