Skip to content

Commit fdc05c7

Browse files
marc-hbkv2019i
authored andcommitted
xtensa-build-zephyr.py: extract new function rimage_options()
Unlike rimage_configuration(), rimage_options() will be kept free of side-effect. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 3ac849e commit fdc05c7

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

scripts/xtensa-build-zephyr.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,16 @@ def rimage_configuration(platform_dict):
526526

527527
rimage_executable = shutil.which("rimage", path=RIMAGE_BUILD_DIR)
528528

529-
sign_cmd += ["--tool-path", rimage_executable]
529+
sign_cmd += ["--tool-path", rimage_executable, "--"]
530+
531+
sign_cmd += rimage_options(platform_dict)
532+
return sign_cmd
533+
534+
535+
def rimage_options(platform_dict):
536+
537+
sign_cmd = []
538+
530539
signing_key = ""
531540
if args.key:
532541
signing_key = args.key
@@ -535,7 +544,7 @@ def rimage_configuration(platform_dict):
535544
else:
536545
signing_key = default_rimage_key
537546

538-
sign_cmd += ["--", "-k", str(signing_key)]
547+
sign_cmd += ["-k", str(signing_key)]
539548

540549
sof_fw_vers = get_sof_version()
541550

0 commit comments

Comments
 (0)