From ebcd26feb79c4ec186b985674de613f36afce8fe Mon Sep 17 00:00:00 2001 From: Pan Xiuli Date: Mon, 19 Oct 2020 13:33:42 +0000 Subject: [PATCH 1/2] logger: fix opt for filter parameter The -F filter option has argument, we should use F: instead of F in the optstring. Fixes: #3530 Signed-off-by: Pan Xiuli --- tools/logger/logger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/logger/logger.c b/tools/logger/logger.c index cd9462dffcbd..ab3f29b94680 100644 --- a/tools/logger/logger.c +++ b/tools/logger/logger.c @@ -161,7 +161,7 @@ static int append_filter_config(struct convert_config *config, const char *input int main(int argc, char *argv[]) { - static const char optstring[] = "ho:i:l:ps:c:u:tv:rd:Lf:gFn"; + static const char optstring[] = "ho:i:l:ps:c:u:tv:rd:Lf:gF:n"; struct convert_config config; unsigned int baud = 0; const char *snapshot_file = 0; From def561ed837f921175e679be853542d0e96a7f46 Mon Sep 17 00:00:00 2001 From: Pan Xiuli Date: Mon, 19 Oct 2020 13:40:54 +0000 Subject: [PATCH 2/2] logger: change the usage string for filter Change the misleading usage info for filter. Add format as tips for filter string. Signed-off-by: Pan Xiuli --- tools/logger/logger.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/logger/logger.c b/tools/logger/logger.c index ab3f29b94680..429c71002f18 100644 --- a/tools/logger/logger.c +++ b/tools/logger/logger.c @@ -60,7 +60,8 @@ static void usage(void) APP_NAME); fprintf(stdout, "%s:\t -d *.ldc_file \t\tDump ldc_file information\n", APP_NAME); - fprintf(stdout, "%s:\t -F path\t\tUpdate trace filtering\n", + fprintf(stdout, "%s:\t -F filter\t\tUpdate trace filter, format: " + "=[, ]\n", APP_NAME); exit(0); }