From aa03779e21e2f6482d0eedec67bc2a1925ff5456 Mon Sep 17 00:00:00 2001
From: Marc Herbert <marc.herbert@intel.com>
Date: Mon, 22 Mar 2021 20:52:31 +0000
Subject: [PATCH] topology/cmake: add missing .m4 dependency, fixes incremental
 build

There was no [MAIN_]DEPENDS on the .m4 source file, so changes were not
triggering any rebuild.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
---
 scripts/build-tools.sh        | 2 +-
 tools/topology/CMakeLists.txt | 5 +++--
 tools/topology/get_abi.sh     | 3 +++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/scripts/build-tools.sh b/scripts/build-tools.sh
index 6718f915689d..1edee2c513e2 100755
--- a/scripts/build-tools.sh
+++ b/scripts/build-tools.sh
@@ -60,8 +60,8 @@ Build commands for respective tools:
         ctl:        make -C "$BUILD_TOOLS_DIR" sof-ctl
         logger:     make -C "$BUILD_TOOLS_DIR" sof-logger
         probes:     make -C "$BUILD_TOOLS_DIR" sof-probes
-        tests:      make -C "$BUILD_TOOLS_DIR" tests
         topologies: make -C "$BUILD_TOOLS_DIR" topologies
+        test tplgs: make -C "$BUILD_TOOLS_DIR" tests
         fuzzer:     make -C "$BUILD_TOOLS_DIR/fuzzer"
 EOFUSAGE
 }
diff --git a/tools/topology/CMakeLists.txt b/tools/topology/CMakeLists.txt
index cce80a38dcd9..f98cc751a75d 100644
--- a/tools/topology/CMakeLists.txt
+++ b/tools/topology/CMakeLists.txt
@@ -150,7 +150,7 @@ foreach(tplg ${TPLGS})
 	endif()
 
 	add_custom_command(
-		OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${output}.conf
+		OUTPUT ${output}.conf
 		COMMAND m4 --fatal-warnings
 			${DEFINES}
 			-I ${CMAKE_CURRENT_SOURCE_DIR}/m4
@@ -161,6 +161,7 @@ foreach(tplg ${TPLGS})
 			${CMAKE_CURRENT_SOURCE_DIR}/common/abi.m4
 			${CMAKE_CURRENT_SOURCE_DIR}/${input}.m4
 			> ${output}.conf
+		MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/${input}.m4
 		DEPENDS abi
 		VERBATIM
 		USES_TERMINAL
@@ -184,7 +185,7 @@ foreach(tplg ${TPLGS})
 	add_custom_command(
 		OUTPUT ${output}.tplg
 		COMMAND alsatplg \$\${VERBOSE:+-v 1} -c ${output}.conf -o ${output}.tplg
-		DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${output}.conf
+		MAIN_DEPENDENCY ${output}.conf
 		USES_TERMINAL
 	)
 
diff --git a/tools/topology/get_abi.sh b/tools/topology/get_abi.sh
index 06f15b84330a..424336761a4a 100755
--- a/tools/topology/get_abi.sh
+++ b/tools/topology/get_abi.sh
@@ -2,6 +2,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation. All rights reserved.
 
+
+set -e
+
 MAJOR=`grep '#define SOF_ABI_MAJOR ' $1/src/include/kernel/abi.h | grep -E ".[[:digit:]]$" -o`
 MINOR=`grep '#define SOF_ABI_MINOR ' $1/src/include/kernel/abi.h | grep -E ".[[:digit:]]$" -o`
 PATCH=`grep '#define SOF_ABI_PATCH ' $1/src/include/kernel/abi.h | grep -E ".[[:digit:]]$" -o`