From 1d9c493dd0123cf1efd328631c6c0f67c32f4ee0 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 23 Jun 2021 23:40:29 +0000 Subject: [PATCH] apollolake/memory.h: sort regions table comment by address This makes it possible to match the table with the definitions. Pure comment change, no code change. Signed-off-by: Marc Herbert --- .../apollolake/include/platform/lib/memory.h | 18 +++++++++++------- .../intel/cavs/include/cavs/lib/mailbox.h | 5 ++++- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/platform/apollolake/include/platform/lib/memory.h b/src/platform/apollolake/include/platform/lib/memory.h index 9dc19af5dfb1..74bc6e9681c1 100644 --- a/src/platform/apollolake/include/platform/lib/memory.h +++ b/src/platform/apollolake/include/platform/lib/memory.h @@ -125,15 +125,13 @@ #define EXT_MANIFEST_ELF_SIZE 0x2000000 /* - * The HP SRAM Region Apollolake is organised like this :- + * The HP SRAM Region Apollolake is organised like this. Lower + * addresses are first. See also mailbox.h. + * * +--------------------------------------------------------------------------+ * | Offset | Region | Size | * +------------------+-------------------------+-----------------------------+ - * | SRAM_SW_REG_BASE | SW Registers W0 | SRAM_SW_REG_SIZE | - * +------------------+-------------------------+-----------------------------+ - * | SRAM_OUTBOX_BASE | Outbox W0 | SRAM_MAILBOX_SIZE | - * +------------------+-------------------------+-----------------------------+ - * | SRAM_INBOX_BASE | Inbox W1 | SRAM_INBOX_SIZE | + * | SRAM_TRACE_BASE | Trace Buffer W3 | SRAM_TRACE_SIZE | * +------------------+-------------------------+-----------------------------+ * | SRAM_DEBUG_BASE | Debug data W2 | SRAM_DEBUG_SIZE | * +------------------+-------------------------+-----------------------------+ @@ -141,7 +139,13 @@ * +------------------+-------------------------+-----------------------------+ * | SRAM_STREAM_BASE | Stream data W2 | SRAM_STREAM_SIZE | * +------------------+-------------------------+-----------------------------+ - * | SRAM_TRACE_BASE | Trace Buffer W3 | SRAM_TRACE_SIZE | + * | SRAM_INBOX_BASE | Inbox W1 | SRAM_INBOX_SIZE | + * +------------------+-------------------------+-----------------------------+ + * | SRAM_SW_REG_BASE | SW Registers W0 | SRAM_SW_REG_SIZE | + * +------------------+-------------------------+-----------------------------+ + * | SRAM_OUTBOX_BASE | Outbox W0 | SRAM_OUTBOX_SIZE | + * +------------------+-------------------------+-----------------------------+ + * * +------------------+-------------------------+-----------------------------+ * | SOF_FW_START | text | | * | | data | | diff --git a/src/platform/intel/cavs/include/cavs/lib/mailbox.h b/src/platform/intel/cavs/include/cavs/lib/mailbox.h index d0678e7a887f..39a85f3266b1 100644 --- a/src/platform/intel/cavs/include/cavs/lib/mailbox.h +++ b/src/platform/intel/cavs/include/cavs/lib/mailbox.h @@ -16,7 +16,10 @@ #include /* - * The Window Region on HPSRAM for cAVS platforms is organised like this :- + * The Window Region on HPSRAM for cAVS platforms is organised like + * this. The actual region order is platform-specific, see memory.h + * files. + * * +--------------------------------------------------------------------------+ * | Offset | Region | Size | * +---------------------+----------------+-----------------------------------+