From 6f968dcf8e54faafd3c90ecaab5d4b029cf08ca6 Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:02:17 +0300 Subject: [PATCH 1/6] Audio: IGO NR: Avoid warning about unused variable This change avoids warning and error about: sof/src/audio/igo_nr/igo_nr.c:678:20: error: unused variable 'cd' [-Werror,-Wunused-variable] struct comp_data *cd = module_get_private_data(mod); Signed-off-by: Seppo Ingalsuo --- src/audio/igo_nr/igo_nr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/audio/igo_nr/igo_nr.c b/src/audio/igo_nr/igo_nr.c index f53124e71e6e..4e206b55d6d7 100644 --- a/src/audio/igo_nr/igo_nr.c +++ b/src/audio/igo_nr/igo_nr.c @@ -675,7 +675,7 @@ static int igo_nr_set_config(struct processing_module *mod, uint32_t param_id, static void igo_nr_print_config(struct processing_module *mod) { - struct comp_data *cd = module_get_private_data(mod); + struct comp_data __maybe_unused *cd = module_get_private_data(mod); struct comp_dev *dev = mod->dev; comp_dbg(dev, " igo_params_ver %d", From cd7e4d565917117ad46e5a693364301062cc91db Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:16:55 +0300 Subject: [PATCH 2/6] IPC4: Helper: Avoid warning about unused in ipc4_get_drv() This change avoids warning/error: sof/src/ipc/ipc4/helper.c:945:31: error: unused variable 'sof_uuid' [-Werror,-Wunused-variable] Signed-off-by: Seppo Ingalsuo --- src/ipc/ipc4/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipc/ipc4/helper.c b/src/ipc/ipc4/helper.c index f727d212f179..09de3e448aa2 100644 --- a/src/ipc/ipc4/helper.c +++ b/src/ipc/ipc4/helper.c @@ -942,7 +942,7 @@ int ipc4_process_on_core(uint32_t core, bool blocking) __cold static const struct comp_driver *ipc4_get_drv(const void *uuid) { - const struct sof_uuid *const sof_uuid = (const struct sof_uuid *)uuid; + const struct sof_uuid *const __maybe_unused sof_uuid = (const struct sof_uuid *)uuid; struct comp_driver_list *drivers = comp_drivers_get(); struct list_item *clist; const struct comp_driver *drv = NULL; From d2e6b3aed6b7266acfeb025bfc17b33ebaa3ee01 Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:22:34 +0300 Subject: [PATCH 3/6] Audio: Smart Amp: Avoid warning about unused The variable sink_ch is unused. This avoids warning/error: sof/workspace/sof/src/audio/smart_amp/smart_amp_generic.c:224:6: error: unused variable 'sink_ch' [-Werror,-Wunused-variable] Signed-off-by: Seppo Ingalsuo --- src/audio/smart_amp/smart_amp_generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/audio/smart_amp/smart_amp_generic.c b/src/audio/smart_amp/smart_amp_generic.c index 5f6a1698d16b..91223eb398bd 100644 --- a/src/audio/smart_amp/smart_amp_generic.c +++ b/src/audio/smart_amp/smart_amp_generic.c @@ -221,7 +221,6 @@ static void feed_s32_to_s24(const struct smart_amp_mod_stream *sink_mod, uint32_ const struct audio_stream __sparse_cache *sink) { int i; - int sink_ch = audio_stream_get_channels(sink); int n_mod = frames * sink_mod->channels; int32_t *mod_ptr = (int32_t *)sink_mod->buf.data; From 55a05c81876227da2d0da2b2000a94be39621b43 Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:30:13 +0300 Subject: [PATCH 4/6] Platform: POSIX: Avoid warning/error about unused This change avoid errors: sof/src/platform/posix/ipc.c:48:7: error: unused variable 'comp_new' [-Werror,-Wunused-variable] sof/src/platform/posix/ipc.c:49:6: error: unused variable 'comp_idx' [-Werror,-Wunused-variable] Signed-off-by: Seppo Ingalsuo --- src/platform/posix/ipc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/platform/posix/ipc.c b/src/platform/posix/ipc.c index b8c54b9a38d9..f9fc0213987f 100644 --- a/src/platform/posix/ipc.c +++ b/src/platform/posix/ipc.c @@ -45,8 +45,6 @@ static size_t fuzz_in_sz; static void fuzz_isr(const void *arg) { size_t rem, i, n = MIN(posix_fuzz_sz, sizeof(fuzz_in) - fuzz_in_sz); - bool comp_new = false; - int comp_idx = 0; for (i = 0; i < n; i++) fuzz_in[fuzz_in_sz++] = posix_fuzz_buf[i]; @@ -68,6 +66,9 @@ static void fuzz_isr(const void *arg) fuzz_in_sz = rem; #ifdef CONFIG_IPC_MAJOR_3 + bool comp_new = false; + int comp_idx = 0; + // One special case: a first byte of 0xff (which is in the // otherwise-ignored size value at the front of the command -- // we rewrite those) is interpreted as a "component new" From 4129dd07e0e30d0ea7248bbd739f17bb27de161e Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:35:50 +0300 Subject: [PATCH 5/6] Audio: Smart Amp: Remove unused variable rate This change fixes warning/error: sof/src/audio/smart_amp/smart_amp.c:736:11: error: unused variable 'rate' [-Werror,-Wunused-variable] Signed-off-by: Seppo Ingalsuo --- src/audio/smart_amp/smart_amp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/audio/smart_amp/smart_amp.c b/src/audio/smart_amp/smart_amp.c index 6cb396a4c153..24415edf36ee 100644 --- a/src/audio/smart_amp/smart_amp.c +++ b/src/audio/smart_amp/smart_amp.c @@ -733,7 +733,6 @@ static int smart_amp_prepare(struct comp_dev *dev) struct smart_amp_data *sad = comp_get_drvdata(dev); uint16_t ff_src_fmt, fb_src_fmt, resolved_mod_fmt; uint32_t least_req_depth; - uint32_t rate; int ret; comp_dbg(dev, "smart_amp_prepare()"); From 6d77c9dd0a0f793d27726550c671045aa5533474 Mon Sep 17 00:00:00 2001 From: Seppo Ingalsuo Date: Fri, 9 May 2025 15:42:14 +0300 Subject: [PATCH 6/6] Platform: POSIX: Remove unused variable cc This change avoids error: sof/src/platform/posix/ipc.c:90:23: error: unused variable 'cc' [-Werror,-Wunused-variable] Signed-off-by: Seppo Ingalsuo --- src/platform/posix/ipc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/platform/posix/ipc.c b/src/platform/posix/ipc.c index f9fc0213987f..701686e6ff97 100644 --- a/src/platform/posix/ipc.c +++ b/src/platform/posix/ipc.c @@ -87,8 +87,6 @@ static void fuzz_isr(const void *arg) // on only rarely, fill it in manually. *(uint32_t *)global_ipc->comp_data = msgsz; - struct sof_ipc_comp *cc = global_ipc->comp_data; - // "Adjust" the command to represent a "comp new" command per // above. Basically we want to copy in the UUID value for one // of the runtime-enumerated drivers based on data already