From a393b7892fe9a0aced411f68e3b736c3c1cfa1cd Mon Sep 17 00:00:00 2001
From: onthepeakofnormal <gius_martin@yahoo.de>
Date: Sat, 28 May 2022 11:32:12 +0200
Subject: [PATCH 1/2] if first argument of euclid is negative, apply euclidInv.
 this is also patternable. + tests fixes #915

---
 src/Sound/Tidal/UI.hs      | 10 ++++++----
 test/Sound/Tidal/UITest.hs |  9 +++++++++
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/Sound/Tidal/UI.hs b/src/Sound/Tidal/UI.hs
index 369bbf122..57f70a4fa 100644
--- a/src/Sound/Tidal/UI.hs
+++ b/src/Sound/Tidal/UI.hs
@@ -110,7 +110,7 @@ rand :: Fractional a => Pattern a
 rand = Pattern (\(State a@(Arc s e) _) -> [Event (Context []) Nothing a (realToFrac $ (timeToRand ((e + s)/2) :: Double))])
 
 -- | Boolean rand - a continuous stream of true/false values, with a 50/50 chance.
-brand :: Pattern Bool 
+brand :: Pattern Bool
 brand = _brandBy 0.5
 
 -- | Boolean rand with probability as input, e.g. brandBy 0.25 is 25% chance of being true.
@@ -755,7 +755,8 @@ euclid :: Pattern Int -> Pattern Int -> Pattern a -> Pattern a
 euclid = tParam2 _euclid
 
 _euclid :: Int -> Int -> Pattern a -> Pattern a
-_euclid n k a = fastcat $ fmap (bool silence a) $ bjorklund (n,k)
+_euclid n k a | n >= 0 = fastcat $ fmap (bool silence a) $ bjorklund (n,k)
+              | otherwise = _euclidInv (-n) k a
 
 {- | `euclidfull n k pa pb` stacks @e n k pa@ with @einv n k pb@ -}
 euclidFull :: Pattern Int -> Pattern Int -> Pattern a -> Pattern a -> Pattern a
@@ -809,7 +810,8 @@ euclidInv :: Pattern Int -> Pattern Int -> Pattern a -> Pattern a
 euclidInv = tParam2 _euclidInv
 
 _euclidInv :: Int -> Int -> Pattern a -> Pattern a
-_euclidInv n k a = fastcat $ fmap (bool a silence) $ bjorklund (n,k)
+_euclidInv n k a | n >= 0 = fastcat $ fmap (bool a silence) $ bjorklund (n,k)
+                 | otherwise = _euclid (-n) k a
 
 index :: Real b => b -> Pattern b -> Pattern c -> Pattern c
 index sz indexpat pat =
@@ -1468,7 +1470,7 @@ rolledBy "<1 -0.5 0.25 -0.125>" $ note "c'maj9" # s "superpiano"
 rolledWith :: Ratio Integer -> Pattern a -> Pattern a
 rolledWith t = withEvents aux
          where aux es = concatMap (steppityIn) (groupBy (\a b -> whole a == whole b) $ ((isRev t) es))
-               isRev b = (\x -> if x > 0 then id else reverse ) b 
+               isRev b = (\x -> if x > 0 then id else reverse ) b
                steppityIn xs = mapMaybe (\(n, ev) -> (timeguard n xs ev t)) $ enumerate xs
                timeguard _ _ ev 0 = return ev
                timeguard n xs ev _ = (shiftIt n (length xs) ev)
diff --git a/test/Sound/Tidal/UITest.hs b/test/Sound/Tidal/UITest.hs
index 4a22e7717..ca95aecf0 100644
--- a/test/Sound/Tidal/UITest.hs
+++ b/test/Sound/Tidal/UITest.hs
@@ -306,6 +306,15 @@ run =
             (euclid 11 24 "x", "x ~ ~ x ~ x ~ x ~ x ~ x ~ ~ x ~ x ~ x ~ x ~ x ~"),
             (euclid 13 24 "x", "x ~ x x ~ x ~ x ~ x ~ x ~ x x ~ x ~ x ~ x ~ x ~")
           ] :: [(Pattern String, String)])
+      it "can be called with a negative first value to give the inverse" $ do
+        compareP (Arc 0 1)
+          (euclid (-3) 8 ("bd" :: Pattern String))
+          (euclidInv 3 8 ("bd" :: Pattern String))
+      it "can be called with a negative first value to give the inverse (patternable)" $ do
+        compareP (Arc 0 1)
+          (euclid (-3) 8 ("bd" :: Pattern String))
+          ("bd(-3,8)" :: Pattern String)
+
 
     describe "wedge" $ do
       it "should not freeze tidal amount is 1" $ do

From ccec207286d7304c42e04adab00460e4aac27d2f Mon Sep 17 00:00:00 2001
From: Martin <58735735+polymorphicengine@users.noreply.github.com>
Date: Sat, 28 May 2022 14:06:03 +0200
Subject: [PATCH 2/2] Update UI.hs

---
 src/Sound/Tidal/UI.hs | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Sound/Tidal/UI.hs b/src/Sound/Tidal/UI.hs
index 57f70a4fa..027652a10 100644
--- a/src/Sound/Tidal/UI.hs
+++ b/src/Sound/Tidal/UI.hs
@@ -718,6 +718,8 @@ In the above, three sounds are picked from the pattern on the right according
 to the structure given by the `e 3 8`. It ends up picking two `bd` sounds, a
 `cp` and missing the `sn` entirely.
 
+A negative first argument provides the inverse of the euclidean pattern.
+
 These types of sequences use "Bjorklund's algorithm", which wasn't made for
 music but for an application in nuclear physics, which is exciting. More
 exciting still is that it is very similar in structure to the one of the first
@@ -756,7 +758,7 @@ euclid = tParam2 _euclid
 
 _euclid :: Int -> Int -> Pattern a -> Pattern a
 _euclid n k a | n >= 0 = fastcat $ fmap (bool silence a) $ bjorklund (n,k)
-              | otherwise = _euclidInv (-n) k a
+              | otherwise = fastcat $ fmap (bool a silence) $ bjorklund (-n,k)
 
 {- | `euclidfull n k pa pb` stacks @e n k pa@ with @einv n k pb@ -}
 euclidFull :: Pattern Int -> Pattern Int -> Pattern a -> Pattern a -> Pattern a
@@ -810,8 +812,7 @@ euclidInv :: Pattern Int -> Pattern Int -> Pattern a -> Pattern a
 euclidInv = tParam2 _euclidInv
 
 _euclidInv :: Int -> Int -> Pattern a -> Pattern a
-_euclidInv n k a | n >= 0 = fastcat $ fmap (bool a silence) $ bjorklund (n,k)
-                 | otherwise = _euclid (-n) k a
+_euclidInv n k a = _euclid (-n) k a
 
 index :: Real b => b -> Pattern b -> Pattern c -> Pattern c
 index sz indexpat pat =