From 837a0a3d5f6a9de8803e4c3d26238f5a0f781749 Mon Sep 17 00:00:00 2001 From: Liangliang Gu Date: Thu, 28 Oct 2021 16:28:27 +0800 Subject: [PATCH] cherry pick #300 to release-3.1 Signed-off-by: ti-srebot --- src/main/java/org/tikv/common/TiSession.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/tikv/common/TiSession.java b/src/main/java/org/tikv/common/TiSession.java index 291bec90091..d88b7e85ef3 100644 --- a/src/main/java/org/tikv/common/TiSession.java +++ b/src/main/java/org/tikv/common/TiSession.java @@ -71,11 +71,14 @@ public class TiSession implements AutoCloseable { private MetricsServer metricsServer; public TiSession(TiConfiguration conf) { + // may throw org.tikv.common.MetricsServer - http server not up + // put it at the beginning of this function to avoid unclosed Thread + this.metricsServer = MetricsServer.getInstance(conf); + this.conf = conf; this.channelFactory = new ChannelFactory(conf.getMaxFrameSize()); this.client = PDClient.createRaw(conf, channelFactory); this.enableGrpcForward = conf.getEnableGrpcForward(); - this.metricsServer = MetricsServer.getInstance(conf); if (this.enableGrpcForward) { logger.info("enable grpc forward for high available"); }