diff --git a/src/main/java/org/tikv/common/TiConfiguration.java b/src/main/java/org/tikv/common/TiConfiguration.java index f7a0e5008aa..b327116c572 100644 --- a/src/main/java/org/tikv/common/TiConfiguration.java +++ b/src/main/java/org/tikv/common/TiConfiguration.java @@ -334,8 +334,8 @@ private static ReplicaRead getReplicaRead(String key) { private boolean metricsEnable = getBoolean(TIKV_METRICS_ENABLE); private int metricsPort = getInt(TIKV_METRICS_PORT); - private final int grpcHealthCheckTimeout = getInt(TIKV_GRPC_HEALTH_CHECK_TIMEOUT); - private final int healthCheckPeriodDuration = getInt(TIKV_HEALTH_CHECK_PERIOD_DURATION); + private int grpcHealthCheckTimeout = getInt(TIKV_GRPC_HEALTH_CHECK_TIMEOUT); + private int healthCheckPeriodDuration = getInt(TIKV_HEALTH_CHECK_PERIOD_DURATION); private final String networkMappingName = get(TIKV_NETWORK_MAPPING_NAME); private HostMapping hostMapping = null; @@ -716,10 +716,18 @@ public long getGrpcHealthCheckTimeout() { return this.grpcHealthCheckTimeout; } + public void setGrpcHealthCheckTimeout(int grpcHealthCheckTimeout) { + this.grpcHealthCheckTimeout = grpcHealthCheckTimeout; + } + public long getHealthCheckPeriodDuration() { return this.healthCheckPeriodDuration; } + public void setHealthCheckPeriodDuration(int healthCheckPeriodDuration) { + this.healthCheckPeriodDuration = healthCheckPeriodDuration; + } + public boolean isEnableAtomicForCAS() { return enableAtomicForCAS; } diff --git a/src/test/java/org/tikv/common/TiConfigurationTest.java b/src/test/java/org/tikv/common/TiConfigurationTest.java index 4676f56a49a..8587ecb69b2 100644 --- a/src/test/java/org/tikv/common/TiConfigurationTest.java +++ b/src/test/java/org/tikv/common/TiConfigurationTest.java @@ -17,7 +17,10 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; +import static org.tikv.common.ConfigUtils.TIKV_GRPC_HEALTH_CHECK_TIMEOUT; +import static org.tikv.common.ConfigUtils.TIKV_HEALTH_CHECK_PERIOD_DURATION; +import org.junit.Assert; import org.junit.Test; public class TiConfigurationTest { @@ -34,6 +37,31 @@ public void tiFlashDefaultValueTest() { assertFalse(conf.isTiFlashEnabled()); } + @Test + public void testGrpcHealthCheckTimeoutValue() { + TiConfiguration conf = TiConfiguration.createDefault(); + // default value + Assert.assertEquals( + TiConfiguration.getInt(TIKV_GRPC_HEALTH_CHECK_TIMEOUT), conf.getGrpcHealthCheckTimeout()); + // new value + int newValue = 100000; + conf.setGrpcHealthCheckTimeout(newValue); + Assert.assertEquals(newValue, conf.getGrpcHealthCheckTimeout()); + } + + @Test + public void testHealthCheckPeriodDurationValue() { + TiConfiguration conf = TiConfiguration.createDefault(); + // default value + Assert.assertEquals( + TiConfiguration.getInt(TIKV_HEALTH_CHECK_PERIOD_DURATION), + conf.getHealthCheckPeriodDuration()); + // new value + int newValue = 100000; + conf.setHealthCheckPeriodDuration(newValue); + Assert.assertEquals(newValue, conf.getHealthCheckPeriodDuration()); + } + @Test public void testGrpcIdleTimeoutValue() { TiConfiguration conf = TiConfiguration.createDefault();