From 9a3ebbdb02bc87255411985d17e32b2d6902ebb5 Mon Sep 17 00:00:00 2001 From: shiyuhang <1136742008@qq.com> Date: Tue, 1 Nov 2022 18:23:30 +0800 Subject: [PATCH 1/3] avoid negative number Signed-off-by: shiyuhang <1136742008@qq.com> --- src/main/java/org/tikv/common/region/RegionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/tikv/common/region/RegionManager.java b/src/main/java/org/tikv/common/region/RegionManager.java index 45cfc5160d9..8fa09b496a8 100644 --- a/src/main/java/org/tikv/common/region/RegionManager.java +++ b/src/main/java/org/tikv/common/region/RegionManager.java @@ -205,7 +205,7 @@ public Pair getRegionStorePairByKey( } // select a tiflash with RR strategy if (tiflashStores.size() > 0) { - store = tiflashStores.get(tiflashStoreIndex.getAndIncrement() % tiflashStores.size()); + store = tiflashStores.get(Math.abs(tiflashStoreIndex.getAndIncrement() % tiflashStores.size())); } if (store == null) { From 9008d884b79c51c04fa83148188a78ee4a2da5d2 Mon Sep 17 00:00:00 2001 From: shiyuhang <1136742008@qq.com> Date: Tue, 1 Nov 2022 19:32:54 +0800 Subject: [PATCH 2/3] avoid negative number Signed-off-by: shiyuhang <1136742008@qq.com> --- src/main/java/org/tikv/common/region/RegionManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/tikv/common/region/RegionManager.java b/src/main/java/org/tikv/common/region/RegionManager.java index 8fa09b496a8..d644bba4170 100644 --- a/src/main/java/org/tikv/common/region/RegionManager.java +++ b/src/main/java/org/tikv/common/region/RegionManager.java @@ -205,7 +205,9 @@ public Pair getRegionStorePairByKey( } // select a tiflash with RR strategy if (tiflashStores.size() > 0) { - store = tiflashStores.get(Math.abs(tiflashStoreIndex.getAndIncrement() % tiflashStores.size())); + store = + tiflashStores.get( + Math.floorMod(tiflashStoreIndex.getAndIncrement(), tiflashStores.size())); } if (store == null) { From e9a1fe283cd76b437ccd1ecc7c5b1baa8d094e4b Mon Sep 17 00:00:00 2001 From: shiyuhang <1136742008@qq.com> Date: Tue, 1 Nov 2022 19:33:18 +0800 Subject: [PATCH 3/3] avoid negative number Signed-off-by: shiyuhang <1136742008@qq.com> --- src/main/java/org/tikv/common/region/RegionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/tikv/common/region/RegionManager.java b/src/main/java/org/tikv/common/region/RegionManager.java index d644bba4170..2d84f9988e4 100644 --- a/src/main/java/org/tikv/common/region/RegionManager.java +++ b/src/main/java/org/tikv/common/region/RegionManager.java @@ -203,7 +203,7 @@ public Pair getRegionStorePairByKey( } } } - // select a tiflash with RR strategy + // select a tiflash with Round-Robin strategy if (tiflashStores.size() > 0) { store = tiflashStores.get(