Skip to content

RFC: Coprocessor Cache#48

Merged
andylokandy merged 2 commits into
masterfrom
cop-cache-rfc
May 31, 2021
Merged

RFC: Coprocessor Cache#48
andylokandy merged 2 commits into
masterfrom
cop-cache-rfc

Conversation

@breezewish
Copy link
Copy Markdown
Member

Signed-off-by: Breezewish breezewish@pingcap.com

Signed-off-by: Breezewish <breezewish@pingcap.com>
@andylokandy
Copy link
Copy Markdown
Contributor

@breeswish Can we merge the RFC now?

@breezewish
Copy link
Copy Markdown
Member Author

Yes, as long as there are enough approvals. @andylokandy

Copy link
Copy Markdown
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it's implemented and delivered 🙃

@andylokandy
Copy link
Copy Markdown
Contributor

/cc @tikv/maintainers

first.

TiDB sends the Coprocessor request with `IsCacheEnabled` and
`RegionRaftApplyIndex` field hen the following condition is met:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "hen"?

Copy link
Copy Markdown
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andylokandy andylokandy merged commit 7bc9b2b into master May 31, 2021
@BusyJay BusyJay deleted the cop-cache-rfc branch May 31, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants