From b794ac8bca5d135a5e13d32ec6cb9a61ff20efc9 Mon Sep 17 00:00:00 2001 From: Michal Michalowski Date: Fri, 27 Sep 2024 17:44:43 +0200 Subject: [PATCH 1/3] chore: remove eslint ingores (not needed) --- src/error.js | 1 - test/integration/parsing/error.js | 1 - 2 files changed, 2 deletions(-) diff --git a/src/error.js b/src/error.js index 198eb96..da537a7 100644 --- a/src/error.js +++ b/src/error.js @@ -49,7 +49,6 @@ export default function error(type) { export function isValidStrict(type) { let valid = false; - // eslint-disable-next-line no-restricted-syntax for (const i in errors) { if (Object.prototype.hasOwnProperty.call(errors, i) && errors[i] === type) { valid = true; diff --git a/test/integration/parsing/error.js b/test/integration/parsing/error.js index 16ce5da..f6068cc 100644 --- a/test/integration/parsing/error.js +++ b/test/integration/parsing/error.js @@ -25,7 +25,6 @@ describe('.parse() error', () => { expect(parser.parse('#N/A')).toMatchObject({ error: '#N/A', result: null }); expect(parser.parse('#N/A!')).toMatchObject({ error: '#ERROR!', result: null }); expect(parser.parse('#N/A?')).toMatchObject({ error: '#ERROR!', result: null }); - /* eslint-disable no-useless-escape */ expect(parser.parse('#NA')).toMatchObject({ error: '#ERROR!', result: null }); }); From 7312a584761692860474ac90ae047967ea0ac995 Mon Sep 17 00:00:00 2001 From: Michal Michalowski Date: Fri, 27 Sep 2024 17:57:24 +0200 Subject: [PATCH 2/3] chore: change branch name to push --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4d697c4..2c4ecb2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,7 +2,7 @@ name: CI on: push: - branches: [develop] + branches: [main] pull_request: jobs: From 07169df5b5ff9cd7debdec175a97d30777412ecc Mon Sep 17 00:00:00 2001 From: Michal Michalowski Date: Fri, 27 Sep 2024 18:09:36 +0200 Subject: [PATCH 3/3] chore: change branch name in semgrep workflow --- .github/workflows/semgrep.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/semgrep.yml b/.github/workflows/semgrep.yml index 0263d60..a305ebd 100644 --- a/.github/workflows/semgrep.yml +++ b/.github/workflows/semgrep.yml @@ -3,7 +3,7 @@ name: Semgrep on: pull_request: - branches: ['develop'] + branches: ['main'] # Schedule the CI job (this method uses cron syntax): schedule: