From 0e96040852b3c68d3d51d63f2e34256077a6c71d Mon Sep 17 00:00:00 2001 From: kotp Date: Mon, 2 Jan 2017 04:46:59 -0500 Subject: [PATCH] A bit more idiomatic Ruby Also, the private call was ineffective. --- exercises/all-your-base/example.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/exercises/all-your-base/example.rb b/exercises/all-your-base/example.rb index 56fc99c341..2a035e0c1b 100644 --- a/exercises/all-your-base/example.rb +++ b/exercises/all-your-base/example.rb @@ -10,17 +10,17 @@ def self.convert(base_from, number_array, base_to) convert_from_canonical_base(number_in_canonical_base, base_to) end - private + private_class_method def self.invalid_inputs?(base_from, number_array, base_to) - number_array.any?{ |number| number < 0 || number >= base_from } || + number_array.any? { |number| number < 0 || number >= base_from } || base_from <= 1 || base_to <= 1 end def self.convert_to_canonical_base(number_array, base) total = 0 number_array.reverse.each_with_index do |number, index| - total += number * base ** index + total += number * base**index end total end @@ -28,9 +28,9 @@ def self.convert_to_canonical_base(number_array, base) def self.convert_from_canonical_base(number, base_to) result = [] current_number = number - while current_number >= base_to do - result << current_number % base_to - current_number = current_number / base_to + while current_number >= base_to + result << current_number % base_to + current_number /= base_to end result << current_number % base_to result.reverse