From 058f8b129e481d4e7dadca4e3577c291e3a62191 Mon Sep 17 00:00:00 2001 From: Nir Friedman Date: Sat, 14 Oct 2023 16:04:13 +0300 Subject: [PATCH 1/2] Fix bug that no more than ConfigEntries per topic can be defined --- admin/kafka_admin.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/admin/kafka_admin.go b/admin/kafka_admin.go index 4ad8c39..fa72ecb 100644 --- a/admin/kafka_admin.go +++ b/admin/kafka_admin.go @@ -10,6 +10,7 @@ package admin import ( "fmt" + "github.com/Shopify/sarama" "github.com/tryfix/errors" "github.com/tryfix/log" @@ -139,7 +140,8 @@ func (c *kafkaAdmin) CreateTopics(topics map[string]*Topic) error { } details.ConfigEntries = map[string]*string{} for cName, config := range info.ConfigEntries { - details.ConfigEntries[cName] = &config + configCpy := config + details.ConfigEntries[cName] = &configCpy } err := c.admin.CreateTopic(name, details, false) From 79897cef415da5e3445b5b633bf4884b0413b1ab Mon Sep 17 00:00:00 2001 From: nirfri Date: Sat, 14 Oct 2023 19:40:20 +0300 Subject: [PATCH 2/2] Update kafka_admin.go --- admin/kafka_admin.go | 1 - 1 file changed, 1 deletion(-) diff --git a/admin/kafka_admin.go b/admin/kafka_admin.go index fa72ecb..2295f10 100644 --- a/admin/kafka_admin.go +++ b/admin/kafka_admin.go @@ -10,7 +10,6 @@ package admin import ( "fmt" - "github.com/Shopify/sarama" "github.com/tryfix/errors" "github.com/tryfix/log"