Skip to content

fix(responsive): prevent images in <figure> from overflowing on mobile#60

Merged
seveibar merged 1 commit into
tscircuit:mainfrom
techmannih:img
May 26, 2025
Merged

fix(responsive): prevent images in <figure> from overflowing on mobile#60
seveibar merged 1 commit into
tscircuit:mainfrom
techmannih:img

Conversation

@techmannih
Copy link
Copy Markdown
Member

fix #59
Screenshot 2025-05-24 014408

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 8:19pm

Copy link
Copy Markdown
Contributor

@MustafaMulla29 MustafaMulla29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its still the same

Screenshot_2025-05-26-14-30-37-41_40deb401b9ffe8e1df2f1cc5ba480b12

This ss is from vercel deployed version

@MustafaMulla29
Copy link
Copy Markdown
Contributor

I think you should test it in phone.

@techmannih
Copy link
Copy Markdown
Member Author

techmannih commented May 26, 2025

@MustafaMulla29 . it still not same.
I have fixed the

issue at the link you mentioned.
However, I’m not sure where we are using in this repo exactly.
Also, I don’t know what the

tag is being used for here. You need to add the link for this

It is fixed as shown your issue.

Screenshot_20250526_144634_Chrome.jpg

@MustafaMulla29
Copy link
Copy Markdown
Contributor

@techmannih ohk sorry I looked at the wrong page
This pr works

@seveibar
Copy link
Copy Markdown
Contributor

I checked the original docs and this PR, I can't see any difference. Can you link to a page that changes? I tried quickstart web and saw no change

@techmannih
Copy link
Copy Markdown
Member Author

techmannih commented May 26, 2025

Where using figure tag in it. This issue fixed that. Yeah I checked now in quick start where using img tag. Will rag new pr with fixed

Like this page using figure tag.
https://docs.tscircuit.com/guides/importing-modules-and-chips/importing-from-jlcpcb

Fixed
https://docs-9sfuqpvwa-tscircuit.vercel.app/guides/importing-modules-and-chips/importing-from-jlcpcb

@seveibar seveibar merged commit 648b337 into tscircuit:main May 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Images are getting cutoff on almost every page

3 participants