From 68f8818bd6d445d27c88d82c9dffc7ee1f7cbbc5 Mon Sep 17 00:00:00 2001
From: Andrii Tsok <andrii@tsok.org>
Date: Sun, 19 Apr 2026 05:13:51 +0000
Subject: [PATCH] fix(env-setup): tolerate GitHub-runner MySQL root auth
 (root/root + auth_socket fallback)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GitHub's ubuntu-latest pre-installs MySQL 8 with root/root credentials,
not the Debian default of auth_socket. The install step was using
`sudo mysql` which matches a fresh apt install but fails with
`Access denied for user 'root'@'localhost' (using password: NO)` on
the pre-installed version.

Probe both auth modes — prefer root/root (GH-runner default), fall
back to `sudo mysql` (fresh apt install / auth_socket). Fail loudly
if neither works so operators on unusual images see a clear error
instead of cryptic access-denied messages further down the pipeline.
---
 actions/environment-setup/action.yml | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/actions/environment-setup/action.yml b/actions/environment-setup/action.yml
index 10279c5..ba27b3c 100644
--- a/actions/environment-setup/action.yml
+++ b/actions/environment-setup/action.yml
@@ -579,19 +579,35 @@ runs:
       shell: bash
       run: |
         set -euo pipefail
-        echo "🧰 Installing MySQL via apt"
-        # GitHub's ubuntu-latest ships with mysql-server pre-installed on most
-        # releases; ensure it's actually available and running.
+        echo "🧰 Installing/starting MySQL"
+        # GitHub's ubuntu-latest ships with mysql-server pre-installed; a
+        # fresh apt install covers clean images.
         if ! command -v mysqld >/dev/null 2>&1; then
           sudo apt-get update -y
           sudo apt-get install -y --no-install-recommends mysql-server
         fi
         sudo service mysql start
-        for i in {1..20}; do
-          if sudo mysql -e 'SELECT 1' >/dev/null 2>&1; then break; fi
+        # Wait up to 30s for MySQL to accept connections. We probe with
+        # several auth modes because GitHub's pre-installed MySQL uses
+        # root/root while a fresh apt install on ubuntu:24.04 uses
+        # auth_socket (sudo-only) — and we have to tolerate both.
+        MYSQL_ROOT=""
+        for _ in {1..30}; do
+          if mysql -uroot -proot -e 'SELECT 1' >/dev/null 2>&1; then
+            MYSQL_ROOT="mysql -uroot -proot"
+            break
+          fi
+          if sudo mysql -e 'SELECT 1' >/dev/null 2>&1; then
+            MYSQL_ROOT="sudo mysql"
+            break
+          fi
           sleep 1
         done
-        sudo mysql -v <<'SQL'
+        if [[ -z "$MYSQL_ROOT" ]]; then
+          echo "::error::cannot authenticate to local MySQL as root (tried root/root and auth_socket)"
+          exit 1
+        fi
+        $MYSQL_ROOT -v <<'SQL'
           CREATE USER IF NOT EXISTS 'mcpg'@'127.0.0.1' IDENTIFIED BY 'mcpg';
           CREATE USER IF NOT EXISTS 'mcpg'@'localhost' IDENTIFIED BY 'mcpg';
           CREATE DATABASE IF NOT EXISTS mcpg_test;