From 88778e36b8fe10bac765dfd78b4240e8b7943d5a Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 16 Jan 2023 15:35:43 -0800 Subject: [PATCH 1/2] Fix .form-control in dark mode --- scss/_root.scss | 5 ----- scss/_variables.scss | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/scss/_root.scss b/scss/_root.scss index f9de30195aab..7841a153eb84 100644 --- a/scss/_root.scss +++ b/scss/_root.scss @@ -115,11 +115,6 @@ --#{$prefix}box-shadow-lg: #{$box-shadow-lg}; --#{$prefix}box-shadow-inset: #{$box-shadow-inset}; - // scss-docs-start form-control-vars - --#{$prefix}form-control-bg: var(--#{$prefix}body-bg); - --#{$prefix}form-control-disabled-bg: var(--#{$prefix}secondary-bg); - // scss-docs-end form-control-vars - // Focus styles // scss-docs-start root-focus-variables --#{$prefix}focus-ring-width: #{$focus-ring-width}; diff --git a/scss/_variables.scss b/scss/_variables.scss index 35f6988c9527..94bcd0f74c93 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -873,9 +873,9 @@ $input-padding-y-lg: $input-btn-padding-y-lg !default; $input-padding-x-lg: $input-btn-padding-x-lg !default; $input-font-size-lg: $input-btn-font-size-lg !default; -$input-bg: var(--#{$prefix}form-control-bg) !default; +$input-bg: var(--#{$prefix}body-bg) !default; $input-disabled-color: null !default; -$input-disabled-bg: var(--#{$prefix}form-control-disabled-bg) !default; +$input-disabled-bg: var(--#{$prefix}secondary-bg) !default; $input-disabled-border-color: null !default; $input-color: var(--#{$prefix}body-color) !default; From 816552d504ca9c0d1ee9e782ed131081d0e43cdf Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Mon, 16 Jan 2023 15:46:56 -0800 Subject: [PATCH 2/2] Remove CSS vars from docs --- site/content/docs/5.3/forms/form-control.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/site/content/docs/5.3/forms/form-control.md b/site/content/docs/5.3/forms/form-control.md index b2abeb7c2469..0c6b5997e516 100644 --- a/site/content/docs/5.3/forms/form-control.md +++ b/site/content/docs/5.3/forms/form-control.md @@ -173,12 +173,6 @@ Learn more about [support for datalist elements](https://caniuse.com/datalist). ## CSS -### Variables - -Form controls make use of a small amount of CSS variables to support custom styling across color modes. - -{{< scss-docs name="form-control-vars" file="scss/_root.scss" >}} - ### Sass variables `$input-*` are shared across most of our form controls (and not buttons).