From f0ffda81dda01e06c3fe11b9fe41af687d3ee5f3 Mon Sep 17 00:00:00 2001 From: louismaximepiton Date: Tue, 7 Feb 2023 10:31:40 +0100 Subject: [PATCH 1/2] Fix + proposal --- site/content/docs/5.3/components/progress.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/site/content/docs/5.3/components/progress.md b/site/content/docs/5.3/components/progress.md index ea9e3d2d2779..fa10cd6f33c4 100644 --- a/site/content/docs/5.3/components/progress.md +++ b/site/content/docs/5.3/components/progress.md @@ -15,7 +15,7 @@ toc: true Progress components are built with two HTML elements, some CSS to set the width, and a few attributes. We don't use [the HTML5 `` element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress), ensuring you can stack progress bars, animate them, and place text labels over them. - We use the `.progress` as a wrapper to indicate the max value of the progress bar. -- The `.progress` wrapper also requires a `role="progress"` and `aria` attributes to make it accessible, including an accessible name (using `aria-label`, `aria-labelledby`, or similar). +- The `.progress` wrapper also requires a `role="progressbar"` and `aria` attributes to make it accessible, including an accessible name (using `aria-label`, `aria-labelledby`, or similar). - We use the inner `.progress-bar` purely for the visual bar and label. - The `.progress-bar` requires an inline style, utility class, or custom CSS to set its width. - We provide a special `.progress-stacked` class to create multiple/stacked progress bars. @@ -57,7 +57,7 @@ Bootstrap provides a handful of [utilities for setting width]({{< docsref "/util You only set a `height` value on the `.progress` container, so if you change that value, the inner `.progress-bar` will automatically resize accordingly. {{< example >}} -
+
@@ -137,13 +137,13 @@ You can include multiple progress components inside a container with `.progress- {{< example >}}
-
+
-
+
-
+
From b107fd2be1f5170e6320160566218757896e94f4 Mon Sep 17 00:00:00 2001 From: louismaximepiton Date: Mon, 13 Feb 2023 08:55:44 +0100 Subject: [PATCH 2/2] fix(review) --- site/content/docs/5.3/components/progress.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/site/content/docs/5.3/components/progress.md b/site/content/docs/5.3/components/progress.md index fa10cd6f33c4..73f131589763 100644 --- a/site/content/docs/5.3/components/progress.md +++ b/site/content/docs/5.3/components/progress.md @@ -137,13 +137,13 @@ You can include multiple progress components inside a container with `.progress- {{< example >}}
-
+
-
+
-
+