From cbaae2098de3c8aac6dae7ea29016a25c3e740f6 Mon Sep 17 00:00:00 2001 From: Chris Date: Thu, 2 Nov 2023 14:58:22 +0000 Subject: [PATCH 1/4] removed fudge factor --- process/superconductors.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/process/superconductors.py b/process/superconductors.py index 964914befb..42af4dd4d3 100644 --- a/process/superconductors.py +++ b/process/superconductors.py @@ -486,13 +486,13 @@ def hijc_rebco(thelium, bmax, strain, bc20max, t_c0): jcrit = (A_t / bmax) * bcrit**b * (bmax / bcrit) ** p * (1 - bmax / bcrit) ** q # Jc times HTS area: default area is width 4mm times HTS layer thickness 1 um, - # divided by the tape area to provide engineering Jc per tape, then multiplied by fraction 0.4 - # to reach the level of current density expected in the space where the tapes are wound in A/m^2! + # divided by the tape area to provide engineering Jc per tape,! + # A scaling factor of 0.4 used to be applied below to assume the difference + # between tape stacks and CORC cable layouts. jcrit = ( jcrit * (rebco_variables.tape_width * rebco_variables.rebco_thickness) / (rebco_variables.tape_width * rebco_variables.tape_thickness) - * 0.4 ) return jcrit, bcrit, tcrit From c685f96ffe438772e15214c351d180e3a75ddc5b Mon Sep 17 00:00:00 2001 From: Chris Date: Thu, 2 Nov 2023 15:02:14 +0000 Subject: [PATCH 2/4] docstring update --- process/superconductors.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/process/superconductors.py b/process/superconductors.py index 42af4dd4d3..029a0dcade 100644 --- a/process/superconductors.py +++ b/process/superconductors.py @@ -456,6 +456,10 @@ def hijc_rebco(thelium, bmax, strain, bc20max, t_c0): considering A(4.2 K) = 2.2e8, A(20 K) = 2.3e8 and A(65 K) = 3.5e8. These values were selected manually. A good fit to the pubished data can be seen in the 4-10 T range but the fit deviates at very low or very high field. + + A scaling factor of 0.4 was originally applied to jcrit to accomodate the models + original purpose of being used with CORC cables, which PROCESS did not model as it + assumed a stacked tape block design """ a = 1.4 From 9d343d9f7b3b6a80b8c05f8b7bacf5199c3942f7 Mon Sep 17 00:00:00 2001 From: Chris Date: Thu, 2 Nov 2023 15:05:12 +0000 Subject: [PATCH 3/4] docstring update 2 --- process/superconductors.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/process/superconductors.py b/process/superconductors.py index 029a0dcade..1e0efdf9da 100644 --- a/process/superconductors.py +++ b/process/superconductors.py @@ -457,9 +457,10 @@ def hijc_rebco(thelium, bmax, strain, bc20max, t_c0): selected manually. A good fit to the pubished data can be seen in the 4-10 T range but the fit deviates at very low or very high field. + C. Ashe 2/11/23 A scaling factor of 0.4 was originally applied to jcrit to accomodate the models original purpose of being used with CORC cables, which PROCESS did not model as it - assumed a stacked tape block design + assumed a stacked tape block design. """ a = 1.4 From b6daf7110a5fe26695f6d09afccef9d0fdcaa736 Mon Sep 17 00:00:00 2001 From: Chris Date: Thu, 2 Nov 2023 15:15:57 +0000 Subject: [PATCH 4/4] test_hijc_rebco test corrected --- tests/unit/test_superconductors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test_superconductors.py b/tests/unit/test_superconductors.py index 3fa3df587c..78309774a7 100644 --- a/tests/unit/test_superconductors.py +++ b/tests/unit/test_superconductors.py @@ -187,6 +187,6 @@ def test_gl_rebco(): def test_hijc_rebco(): jcrit, bcrit, tcrit = superconductors.hijc_rebco(4.75, 7.0, 2, 30.0, 25.0) - assert jcrit == pytest.approx(44418407.919617616) + assert jcrit == pytest.approx(111046017.5) assert bcrit == pytest.approx(22.335736687814954) assert tcrit == pytest.approx(24.999125)