From d946233df6ee6166f5380b3b333340ac9dab221e Mon Sep 17 00:00:00 2001 From: Clair Mould <86794332+clmould@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:34:50 +0000 Subject: [PATCH 1/3] correct error message when acs negative --- process/sctfcoil.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/process/sctfcoil.py b/process/sctfcoil.py index 3016edf86a..1a8435751f 100644 --- a/process/sctfcoil.py +++ b/process/sctfcoil.py @@ -777,7 +777,8 @@ def supercon( jsc: {jsc} iooic: {iooic} jcritsc: {jcritsc} - Check conductor dimensions. fcond likely gone negative. fcond: {fcond} + acs: {acs} + Check conductor dimensions. Cable space area acs likely gone negative. acs: {acs} """ ) @@ -6702,8 +6703,8 @@ def extended_plane_strain( M_ext[1, 0, kk] = rad[kk] ** 2 * (1 - M_ext[0, 0, kk]) M_ext[1, 1, kk] = 1 - rad[kk] ** 2 * M_ext[0, 1, kk] - M_ext[1, 2, kk] = -rad[kk] ** 2 * M_ext[0, 2, kk] - M_ext[1, 4, kk] = -rad[kk] ** 2 * M_ext[0, 4, kk] + M_ext[1, 2, kk] = -(rad[kk] ** 2) * M_ext[0, 2, kk] + M_ext[1, 4, kk] = -(rad[kk] ** 2) * M_ext[0, 4, kk] M_ext[2, 2, kk] = 1.0e0 M_ext[3, 3, kk] = 1.0e0 M_ext[4, 4, kk] = 1.0e0 From 0260a5f4a57bce19e3b6ebbb3fed25137def6348 Mon Sep 17 00:00:00 2001 From: Clair Mould <86794332+clmould@users.noreply.github.com> Date: Wed, 13 Mar 2024 15:14:17 +0000 Subject: [PATCH 2/3] Add to error message to suggest why acs is negative --- process/sctfcoil.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/process/sctfcoil.py b/process/sctfcoil.py index 1a8435751f..2e6dd2e4e9 100644 --- a/process/sctfcoil.py +++ b/process/sctfcoil.py @@ -779,6 +779,9 @@ def supercon( jcritsc: {jcritsc} acs: {acs} Check conductor dimensions. Cable space area acs likely gone negative. acs: {acs} + This is likely because t_cable_radial or t_cable_toroidal has gone negative: + t_cable_radial: {sctfcoil_module.t_cable_radial} + t_cable_toroidal: {sctfcoil_module.t_cable_toroidal} """ ) From c512aedfc4ce4f0a6a04b6f1ce56c0a2356e3c0f Mon Sep 17 00:00:00 2001 From: Clair Mould <86794332+clmould@users.noreply.github.com> Date: Thu, 14 Mar 2024 09:52:27 +0000 Subject: [PATCH 3/3] Remove duplicate acs --- process/sctfcoil.py | 1 - 1 file changed, 1 deletion(-) diff --git a/process/sctfcoil.py b/process/sctfcoil.py index 2e6dd2e4e9..eb57d9f116 100644 --- a/process/sctfcoil.py +++ b/process/sctfcoil.py @@ -777,7 +777,6 @@ def supercon( jsc: {jsc} iooic: {iooic} jcritsc: {jcritsc} - acs: {acs} Check conductor dimensions. Cable space area acs likely gone negative. acs: {acs} This is likely because t_cable_radial or t_cable_toroidal has gone negative: t_cable_radial: {sctfcoil_module.t_cable_radial}