From f943da9dce79a7efd871b31542fcd2599ac0084b Mon Sep 17 00:00:00 2001 From: "Jurgen J. Vinju" Date: Thu, 26 Mar 2026 09:40:30 +0100 Subject: [PATCH 1/3] removed unused monitor clone (also unused in generated code) --- src/org/rascalmpl/runtime/RascalMonitor.java | 77 -------------------- 1 file changed, 77 deletions(-) delete mode 100644 src/org/rascalmpl/runtime/RascalMonitor.java diff --git a/src/org/rascalmpl/runtime/RascalMonitor.java b/src/org/rascalmpl/runtime/RascalMonitor.java deleted file mode 100644 index bbd11278654..00000000000 --- a/src/org/rascalmpl/runtime/RascalMonitor.java +++ /dev/null @@ -1,77 +0,0 @@ -/* - * Copyright (c) 2018-2025, NWO-I CWI, Swat.engineering and Paul Klint - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * - * 1. Redistributions of source code must retain the above copyright notice, - * this list of conditions and the following disclaimer. - * - * 2. Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" - * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE - * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. - */ -package org.rascalmpl.runtime; - -import org.rascalmpl.debug.IRascalMonitor; - -import io.usethesource.vallang.ISourceLocation; - -public class RascalMonitor implements IRascalMonitor { - - @Override - public void jobStart(String name, int workShare, int totalWork) { - // TODO Auto-generated method stub - - } - - @Override - public void jobStep(String name, String message, int workShare) { - // TODO Auto-generated method stub - - } - - @Override - public int jobEnd(String name, boolean succeeded) { - // TODO Auto-generated method stub - return 0; - } - - @Override - public boolean jobIsCanceled(String name) { - // TODO Auto-generated method stub - return false; - } - - @Override - public void jobTodo(String name, int work) { - // TODO Auto-generated method stub - - } - - @Override - public void warning(String message, ISourceLocation src) { - // TODO Auto-generated method stub - - } - - @Override - public void endAllJobs() { - // TODO Auto-generated method stub - - } - -} From 395049e588ffb5b7e1bb9ec28ea70d33d1a715d9 Mon Sep 17 00:00:00 2001 From: "Jurgen J. Vinju" Date: Thu, 26 Mar 2026 09:46:23 +0100 Subject: [PATCH 2/3] moved NullRascalMonitor out of interpreter-specific context to generic IRascalMonitor package --- src/org/rascalmpl/debug/IRascalMonitor.java | 1 - src/org/rascalmpl/ideservices/GsonUtils.java | 2 +- src/org/rascalmpl/interpreter/Evaluator.java | 1 + .../interpreter/NullRascalMonitor.java | 49 ------------------- .../repl/rascal/RascalInterpreterREPL.java | 2 +- .../runtime/RascalRuntimeValueFactory.java | 2 +- .../values/RascalFunctionValueFactory.java | 2 +- .../ParallelEvaluatorsTests.java | 2 +- 8 files changed, 6 insertions(+), 55 deletions(-) delete mode 100644 src/org/rascalmpl/interpreter/NullRascalMonitor.java diff --git a/src/org/rascalmpl/debug/IRascalMonitor.java b/src/org/rascalmpl/debug/IRascalMonitor.java index d64c219a3c8..e40b17abb5e 100644 --- a/src/org/rascalmpl/debug/IRascalMonitor.java +++ b/src/org/rascalmpl/debug/IRascalMonitor.java @@ -20,7 +20,6 @@ import org.jline.terminal.Terminal; import org.rascalmpl.interpreter.BatchProgressMonitor; -import org.rascalmpl.interpreter.NullRascalMonitor; import org.rascalmpl.repl.TerminalProgressBarMonitor; import io.usethesource.vallang.ISourceLocation; diff --git a/src/org/rascalmpl/ideservices/GsonUtils.java b/src/org/rascalmpl/ideservices/GsonUtils.java index 5946c97c3d2..389ae13b1db 100644 --- a/src/org/rascalmpl/ideservices/GsonUtils.java +++ b/src/org/rascalmpl/ideservices/GsonUtils.java @@ -32,7 +32,7 @@ import java.util.function.Consumer; import org.checkerframework.checker.nullness.qual.Nullable; -import org.rascalmpl.interpreter.NullRascalMonitor; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.library.lang.json.internal.JsonValueReader; import org.rascalmpl.library.lang.json.internal.JsonValueWriter; import org.rascalmpl.util.base64.StreamingBase64; diff --git a/src/org/rascalmpl/interpreter/Evaluator.java b/src/org/rascalmpl/interpreter/Evaluator.java index 3d05ba4456f..abd9989d327 100755 --- a/src/org/rascalmpl/interpreter/Evaluator.java +++ b/src/org/rascalmpl/interpreter/Evaluator.java @@ -56,6 +56,7 @@ import org.rascalmpl.debug.IRascalRuntimeInspection; import org.rascalmpl.debug.IRascalSuspendTrigger; import org.rascalmpl.debug.IRascalSuspendTriggerListener; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.exceptions.ImplementationError; import org.rascalmpl.exceptions.StackTrace; import org.rascalmpl.ideservices.IDEServices; diff --git a/src/org/rascalmpl/interpreter/NullRascalMonitor.java b/src/org/rascalmpl/interpreter/NullRascalMonitor.java deleted file mode 100644 index 40353bbb855..00000000000 --- a/src/org/rascalmpl/interpreter/NullRascalMonitor.java +++ /dev/null @@ -1,49 +0,0 @@ -/******************************************************************************* - * Copyright (c) 2009-2013 CWI All rights reserved. This program and the accompanying materials are - * made available under the terms of the Eclipse Public License v1.0 which accompanies this - * distribution, and is available at http://www.eclipse.org/legal/epl-v10.html - * - * Contributors: - * - * * Jurgen J. Vinju - Jurgen.Vinju@cwi.nl - CWI * Anya Helene Bagge - anya@ii.uib.no (Univ. Bergen) - * * Arnold Lankamp - Arnold.Lankamp@cwi.nl - *******************************************************************************/ -package org.rascalmpl.interpreter; - -import org.rascalmpl.debug.IRascalMonitor; - -import io.usethesource.vallang.ISourceLocation; - -public class NullRascalMonitor implements IRascalMonitor { - @Override - public int jobEnd(String name, boolean succeeded) { - return 0; - } - - @Override - public void jobStep(String name, String msg, int inc) { - } - - @Override - public void jobStart(String name, int workShare, int totalWork) { - } - - @Override - public void jobTodo(String name, int work) { - } - - @Override - public boolean jobIsCanceled(String name) { - return false; - } - - @Override - public void warning(String message, ISourceLocation src) { - return; - } - - @Override - public void endAllJobs() { - // nothing - } -} diff --git a/src/org/rascalmpl/repl/rascal/RascalInterpreterREPL.java b/src/org/rascalmpl/repl/rascal/RascalInterpreterREPL.java index 13462e77983..176e32399ea 100644 --- a/src/org/rascalmpl/repl/rascal/RascalInterpreterREPL.java +++ b/src/org/rascalmpl/repl/rascal/RascalInterpreterREPL.java @@ -49,6 +49,7 @@ import org.jline.terminal.Terminal; import org.rascalmpl.dap.DebugSocketServer; import org.rascalmpl.debug.IRascalMonitor; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.exceptions.RascalStackOverflowError; import org.rascalmpl.exceptions.StackTrace; import org.rascalmpl.exceptions.Throw; @@ -57,7 +58,6 @@ import org.rascalmpl.ideservices.RemoteIDEServices; import org.rascalmpl.interpreter.Configuration; import org.rascalmpl.interpreter.Evaluator; -import org.rascalmpl.interpreter.NullRascalMonitor; import org.rascalmpl.interpreter.control_exceptions.InterruptException; import org.rascalmpl.interpreter.control_exceptions.QuitException; import org.rascalmpl.interpreter.staticErrors.StaticError; diff --git a/src/org/rascalmpl/runtime/RascalRuntimeValueFactory.java b/src/org/rascalmpl/runtime/RascalRuntimeValueFactory.java index 5d0bcb92165..73fab13dfed 100644 --- a/src/org/rascalmpl/runtime/RascalRuntimeValueFactory.java +++ b/src/org/rascalmpl/runtime/RascalRuntimeValueFactory.java @@ -36,10 +36,10 @@ import java.util.concurrent.TimeUnit; import java.util.function.BiFunction; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.exceptions.ImplementationError; import org.rascalmpl.exceptions.RuntimeExceptionFactory; import org.rascalmpl.exceptions.Throw; -import org.rascalmpl.interpreter.NullRascalMonitor; import org.rascalmpl.interpreter.asserts.Ambiguous; import org.rascalmpl.parser.ParserGenerator; import org.rascalmpl.parser.gtd.IGTD; diff --git a/src/org/rascalmpl/values/RascalFunctionValueFactory.java b/src/org/rascalmpl/values/RascalFunctionValueFactory.java index 8f587235075..1ad439fb3fb 100644 --- a/src/org/rascalmpl/values/RascalFunctionValueFactory.java +++ b/src/org/rascalmpl/values/RascalFunctionValueFactory.java @@ -26,12 +26,12 @@ import java.util.function.Supplier; import org.rascalmpl.ast.AbstractAST; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.exceptions.ImplementationError; import org.rascalmpl.exceptions.RuntimeExceptionFactory; import org.rascalmpl.exceptions.Throw; import org.rascalmpl.interpreter.IEvaluator; import org.rascalmpl.interpreter.IEvaluatorContext; -import org.rascalmpl.interpreter.NullRascalMonitor; import org.rascalmpl.interpreter.asserts.Ambiguous; import org.rascalmpl.interpreter.control_exceptions.MatchFailed; import org.rascalmpl.interpreter.env.Environment; diff --git a/test/org/rascalmpl/test/functionality/ParallelEvaluatorsTests.java b/test/org/rascalmpl/test/functionality/ParallelEvaluatorsTests.java index 6f5737b9b56..1841f2f8c52 100644 --- a/test/org/rascalmpl/test/functionality/ParallelEvaluatorsTests.java +++ b/test/org/rascalmpl/test/functionality/ParallelEvaluatorsTests.java @@ -15,9 +15,9 @@ import org.junit.Test; import org.rascalmpl.debug.IRascalMonitor; +import org.rascalmpl.debug.NullRascalMonitor; import org.rascalmpl.interpreter.Evaluator; import org.rascalmpl.interpreter.ITestResultListener; -import org.rascalmpl.interpreter.NullRascalMonitor; import org.rascalmpl.shell.ShellEvaluatorFactory; import io.usethesource.vallang.ISourceLocation; From 83372c0b4a5bd5895ce3efd3e71067bd8e4b0bd7 Mon Sep 17 00:00:00 2001 From: "Jurgen J. Vinju" Date: Thu, 26 Mar 2026 10:04:11 +0100 Subject: [PATCH 3/3] forgot to add --- .../rascalmpl/debug/NullRascalMonitor.java | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 src/org/rascalmpl/debug/NullRascalMonitor.java diff --git a/src/org/rascalmpl/debug/NullRascalMonitor.java b/src/org/rascalmpl/debug/NullRascalMonitor.java new file mode 100644 index 00000000000..20b5f7c180f --- /dev/null +++ b/src/org/rascalmpl/debug/NullRascalMonitor.java @@ -0,0 +1,47 @@ +/******************************************************************************* + * Copyright (c) 2009-2013 CWI All rights reserved. This program and the accompanying materials are + * made available under the terms of the Eclipse Public License v1.0 which accompanies this + * distribution, and is available at http://www.eclipse.org/legal/epl-v10.html + * + * Contributors: + * + * * Jurgen J. Vinju - Jurgen.Vinju@cwi.nl - CWI * Anya Helene Bagge - anya@ii.uib.no (Univ. Bergen) + * * Arnold Lankamp - Arnold.Lankamp@cwi.nl + *******************************************************************************/ +package org.rascalmpl.debug; + +import io.usethesource.vallang.ISourceLocation; + +public class NullRascalMonitor implements IRascalMonitor { + @Override + public int jobEnd(String name, boolean succeeded) { + return 0; + } + + @Override + public void jobStep(String name, String msg, int inc) { + } + + @Override + public void jobStart(String name, int workShare, int totalWork) { + } + + @Override + public void jobTodo(String name, int work) { + } + + @Override + public boolean jobIsCanceled(String name) { + return false; + } + + @Override + public void warning(String message, ISourceLocation src) { + return; + } + + @Override + public void endAllJobs() { + // nothing + } +}