Merge pull request #164 from utopia-php/fix-actions-after-response

Fix: Init response to avoid action

Author: Meldiron

composer.lock

@@ -639,6 +639,8 @@ public function send(string $body = ''): void
             $this->end();
         }
 
+        $this->sent = true;
+
         $this->disablePayload();
     }
 

src/Response.php

@@ -43,4 +43,17 @@ public function testFile()
         $response = $this->client->call(Client::METHOD_GET, '/humans.txt');
         $this->assertEquals(204, $response['headers']['status-code']);
     }
+
+    public function testEarlyResponse()
+    {
+        // Ensure response from action is not recieved
+        $response = $this->client->call(Client::METHOD_GET, '/early-response');
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertNotEquals('Action response', $response['body']);
+
+        // 2nd request would catch if action from first ran
+        $response = $this->client->call(Client::METHOD_GET, '/early-response');
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals('Init response. Actioned before: no', $response['body']);
+    }
 }

tests/e2e/ResponseTest.php

@@ -46,6 +46,25 @@
         $response->noContent();
     });
 
+
+// Endpoints for early response
+// Meant to run twice, so init hook can know if action ran
+$earlyResponseAction = 'no';
+App::init()
+    ->groups(['early-response'])
+    ->inject('response')
+    ->action(function (Response $response) use ($earlyResponseAction) {
+        $response->send('Init response. Actioned before: ' . $earlyResponseAction);
+    });
+
+App::get('/early-response')
+    ->groups(['early-response'])
+    ->inject('response')
+    ->action(function (Response $response) use (&$earlyResponseAction) {
+        $earlyResponseAction = 'yes';
+        $response->send('Action response');
+    });
+
 $request = new Request();
 $response = new Response();