From f8e8a9d9e5d5f86791d5a75a220717db28a1455b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matej=20Ba=C4=8Do?= Date: Sun, 7 Sep 2025 20:36:06 +0200 Subject: [PATCH] Fix override default (backwards compatibility) --- src/Response.php | 2 +- tests/e2e/ResponseTest.php | 6 +++--- tests/e2e/server.php | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Response.php b/src/Response.php index 3f76a86..6eb39b1 100755 --- a/src/Response.php +++ b/src/Response.php @@ -542,7 +542,7 @@ public function enablePayload(): static * @param string $value * @param bool $override */ - public function addHeader(string $key, string $value, bool $override = false): static + public function addHeader(string $key, string $value, bool $override = true): static { if ($override) { $this->headers[$key] = $value; diff --git a/tests/e2e/ResponseTest.php b/tests/e2e/ResponseTest.php index 9db080e..b51755b 100644 --- a/tests/e2e/ResponseTest.php +++ b/tests/e2e/ResponseTest.php @@ -160,12 +160,12 @@ public function testSetCookie() { $response = $this->client->call(Client::METHOD_GET, '/set-cookie'); $this->assertEquals(200, $response['headers']['status-code']); - $this->assertEquals('value1', $response['cookies']['key1']); + $this->assertArrayNotHasKey('key1', $response['cookies']); $this->assertEquals('value2', $response['cookies']['key2']); - $response = $this->client->call(Client::METHOD_GET, '/set-cookie-override'); + $response = $this->client->call(Client::METHOD_GET, '/set-cookie-no-override'); $this->assertEquals(200, $response['headers']['status-code']); - $this->assertArrayNotHasKey('key1', $response['cookies']); + $this->assertEquals('value1', $response['cookies']['key1']); $this->assertEquals('value2', $response['cookies']['key2']); } } diff --git a/tests/e2e/server.php b/tests/e2e/server.php index 3cec25d..c7dae34 100644 --- a/tests/e2e/server.php +++ b/tests/e2e/server.php @@ -42,12 +42,12 @@ $response->send('OK'); }); -App::get('/set-cookie-override') +App::get('/set-cookie-no-override') ->inject('request') ->inject('response') ->action(function (Request $request, Response $response) { - $response->addHeader('Set-Cookie', 'key1=value1', override: true); - $response->addHeader('Set-Cookie', 'key2=value2', override: true); + $response->addHeader('Set-Cookie', 'key1=value1', override: false); + $response->addHeader('Set-Cookie', 'key2=value2', override: false); $response->send('OK'); });