From 9fc966308ed8f25547377fc366697b410ae86e61 Mon Sep 17 00:00:00 2001 From: Daniel Hofstetter Date: Tue, 22 Apr 2025 10:12:20 +0200 Subject: [PATCH 1/4] clippy: remove unnecessary semicolon --- src/parse_time_only_str.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parse_time_only_str.rs b/src/parse_time_only_str.rs index f531d31..9fe9c1b 100644 --- a/src/parse_time_only_str.rs +++ b/src/parse_time_only_str.rs @@ -84,7 +84,7 @@ pub(crate) fn parse_time_only(date: DateTime, s: &str) -> Option().unwrap() * 60; } _ => (), - }; + } offset_in_sec *= if &captures["sign"] == "-" { -1 } else { 1 }; FixedOffset::east_opt(offset_in_sec) } From 1a93bb4e3e8e7912a64dbc921b3561c6bcd74609 Mon Sep 17 00:00:00 2001 From: Daniel Hofstetter Date: Tue, 22 Apr 2025 10:27:13 +0200 Subject: [PATCH 2/4] clippy: fix warning from needless_continue lint --- src/parse_time_only_str.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/parse_time_only_str.rs b/src/parse_time_only_str.rs index 9fe9c1b..9d485d0 100644 --- a/src/parse_time_only_str.rs +++ b/src/parse_time_only_str.rs @@ -62,9 +62,8 @@ fn parse_time_with_offset_multi( Err(_) => continue, }; let parsed_dt = date.date_naive().and_time(parsed); - match offset.from_local_datetime(&parsed_dt).single() { - Some(dt) => return Some(dt), - None => continue, + if let Some(dt) = offset.from_local_datetime(&parsed_dt).single() { + return Some(dt); } } None From f6b6b3e4ea2531b991d0861c154bf84a93a1a7e3 Mon Sep 17 00:00:00 2001 From: Daniel Hofstetter Date: Tue, 22 Apr 2025 10:31:02 +0200 Subject: [PATCH 3/4] clippy: fix warning from manual_let_else lint --- src/parse_time_only_str.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/parse_time_only_str.rs b/src/parse_time_only_str.rs index 9d485d0..6816953 100644 --- a/src/parse_time_only_str.rs +++ b/src/parse_time_only_str.rs @@ -57,9 +57,8 @@ fn parse_time_with_offset_multi( time_only_formats::HH_MM_SS, time_only_formats::TWELVE_HOUR, ] { - let parsed = match NaiveTime::parse_from_str(s, fmt) { - Ok(t) => t, - Err(_) => continue, + let Ok(parsed) = NaiveTime::parse_from_str(s, fmt) else { + continue; }; let parsed_dt = date.date_naive().and_time(parsed); if let Some(dt) = offset.from_local_datetime(&parsed_dt).single() { From 28b788a300e9854de9e2a4776a06ca1ebf0bc8d2 Mon Sep 17 00:00:00 2001 From: Daniel Hofstetter Date: Tue, 22 Apr 2025 10:34:39 +0200 Subject: [PATCH 4/4] clippy: fix warnings from redundant_else lint --- src/lib.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index f6148be..c94d108 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -271,9 +271,8 @@ where if let Ok(parsed) = DateTime::parse_from_str(&tmp_s[0..n], fmt) { if tmp_s == s.as_ref() { return Some((parsed, n)); - } else { - return Some((parsed, n - 1)); } + return Some((parsed, n - 1)); } } } @@ -351,9 +350,8 @@ where if let Ok(parsed) = DateTime::parse_from_str(&ts, &f) { if tmp_s == s.as_ref() { return Some((parsed, n)); - } else { - return Some((parsed, n - 1)); } + return Some((parsed, n - 1)); } } }